[PATCH 0/8] Unify escaping/quoting of args in GDB/GDBserver

[Michael Weghorn <m.weghorn@posteo.de>]

Historically, args passed directly on 'gdb --args <args>' invocation
were escaped (when the inferior is started in a shell), while those passed
via 'gdbserver <args>' were not.

That was changed in commit bea571ebd78ee29cb94adf648fbcda1e109e1be6
("Use construct_inferior_arguments which handles special chars",
2020-05-25), so args passed on 'gdbserver <args>' invocation were
quoted as well.
That commit accidently also resulted in args set in target
extended-remote ('set args <args>', 'run <args>')
to be passed to the shell in a quoted way.

Based on the disussion in PR 28392
("gdb server no longer supports argument globbing and variable substitution"),
this patch series addresses this and further unifies the behaviour of
how args (set either directly on GDB/GDBserver invocation or otherwise)
are treated between GDB and GDBserver, also adding a
'--no-escape-args' command line option for GDB and
GDBserver to explicitly disable escaping of args passed directly
on invocation.
It also makes handling args with spaces work in GDBserver
when the 'startup-with-shell' option is off.

(Adding more tests to explicitly test some of the edge cases
in the testsuite probably makes sense once it is clear whether
the approach taken here is considered appropriate.)

Michael Weghorn (8):
  gdbsupport: Extract escaping from 'construct_inferior_arguments'
  gdbsupport: Make escaping in construct_inferior_arguments optional
  PR27989 PR28446 gdbserver: Only escape args passed directly on
    invocation
  PR28392 Add a '--no-escape-args' option for gdb and gdbserver
  Extract helper function from 'fork_inferior'
  Add a 'fork_inferior' overload taking vector of args
  gdbserver: Support args with spaces for no-startup-with-shell case
  gdb: Support some escaping of args with startup-with-shell being off

 gdb/fork-child.c                         |   2 +-
 gdb/infcmd.c                             |   4 +-
 gdb/inferior.h                           |   2 +-
 gdb/main.c                               |   6 +-
 gdb/nat/fork-inferior.c                  | 152 +++++++++++++----------
 gdb/nat/fork-inferior.h                  |  18 ++-
 gdb/remote.c                             |  33 +++--
 gdb/testsuite/gdb.base/args.exp          |  23 +---
 gdb/testsuite/gdb.base/inferior-args.exp |   8 +-
 gdbserver/fork-child.cc                  |  10 +-
 gdbserver/linux-low.cc                   |   4 +-
 gdbserver/netbsd-low.cc                  |   4 +-
 gdbserver/server.cc                      |  74 +++++------
 gdbserver/win32-low.cc                   |   4 +-
 gdbsupport/common-inferior.cc            | 140 +++++++++++----------
 gdbsupport/common-inferior.h             |  16 ++-
 16 files changed, 276 insertions(+), 224 deletions(-)

-- 
2.33.0