From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 5C4453858416 for ; Fri, 22 Oct 2021 12:51:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C4453858416 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x430.google.com with SMTP id m22so3984522wrb.0 for ; Fri, 22 Oct 2021 05:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PUpRPgKjqhgyPt/wJcYvZkoAC5xl6aUA/yMwEf1wA7U=; b=HiIrreZiN3+DwhywZ8d8ry4w3qM47zJfzM9mHh/YyPRD1xlGPll5qvmMU1vC1vChSZ OkIB/VnC8r/gm5/fTmDTTrTEhivm7Vlx64HvbSX40zaweAFeVLYm/Tbey7smu3LzeMle v9zlT/TWHgifHV4Wx3s7VffYqokFvCQ5Tr0imDwOW+yCeSc4WNEzBHd+LPrdM20yRROk u2kmXS4S9RsNB4qlHz/5IjsQF6bDnwgbaSKEVTGZOiwbUAQfHRSL8ebrhitmHLF1joKF b4aK5QTUdjZMw3DluPbYuVyUPaOqakTugFW9Y6QykbaIi6KFZUQZmpreRQn9yy4T6ouV n2Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PUpRPgKjqhgyPt/wJcYvZkoAC5xl6aUA/yMwEf1wA7U=; b=uN0VhGB0GsYEjfdcFE8UEqJobijaex22g4tLgZj3CB6UTAtr7sf6IPu5y55U766KD2 yhg979P3VVacGeQeUzybqrsAU5vzAOBwV40Q+5SXUDyg/f4Yk6GoXI+x6m5Fbkz1ODRE PNcCkovGs4mRYlguzLyECAYEIgY+hMcNxKD3BxgLDT7BgbcDOnSKDLw07hyNSf2qXOPM gjBx9ikiG1+nbcHoLN3v2qUCAE8+RWluB5CzNMvTHGJnaJ8UPjIlHbr/M4fy+2BEmJw8 DXq0bWDcxTjPsUcIG0J3tf9uCFh7bioue3wubovsGBdvNQfOPLZ1u6hz9liDW+cTObxJ fwwg== X-Gm-Message-State: AOAM530IOGAMHWbzXhLC7aC5zIKq3DmcRK6YwyFa3j4226xNZWJo20WH CtCOoKt21IIyuh6/q3JEKvxeKUKMOaSVFQ== X-Google-Smtp-Source: ABdhPJxyv0OG9kXr4E1joa4JxskHZhZxCxSLNOb4XXOuN+8joq/ZvSl1q0eAhSTHQ1fuCyLXQF6XaQ== X-Received: by 2002:adf:a4c5:: with SMTP id h5mr9673866wrb.38.1634907072208; Fri, 22 Oct 2021 05:51:12 -0700 (PDT) Received: from localhost (host212-140-123-151.range212-140.btcentralplus.com. [212.140.123.151]) by smtp.gmail.com with ESMTPSA id g3sm9236772wri.45.2021.10.22.05.51.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 05:51:11 -0700 (PDT) Date: Fri, 22 Oct 2021 13:51:10 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH 1/5] gdb: make disassembler fprintf callback a static member function Message-ID: <20211022125110.GC19507@embecosm.com> References: <132d6990ef6b5bf22cb7c45974f69e10c73199ba.1634162144.git.andrew.burgess@embecosm.com> <875ytrv39f.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875ytrv39f.fsf@tromey.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 13:50:47 up 1 day, 4:24, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2021 12:51:14 -0000 * Tom Tromey [2021-10-20 14:40:28 -0600]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> The disassemble_info structure has four callbacks, we have three of > Andrew> them as static member functions within gdb_disassembler, the forth is > Andrew> just a global static function. > > Andrew> However, this forth callback, is still only used from the > > typo, should say "fourth". > > Otherwise this looks good, thank you. Thanks, I pushed this patch with the fix you suggested. Andrew