From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id A68EF3857C76 for ; Fri, 22 Oct 2021 12:51:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A68EF3857C76 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x334.google.com with SMTP id y132-20020a1c7d8a000000b0032ca5765d6cso117815wmc.0 for ; Fri, 22 Oct 2021 05:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AomieGoEFlPXySesIE/+tFRPVX7arfEMuDfpcHs3kFg=; b=TjkMrI042FJXzo3A48qBwmDCDz6FcnFOSno27a0T0wx/eP9wlHpliYX/UQivGCX8K1 6jnay/nIrjuJqganpdFP3sPj6nrQfEgWnHCrjunScu36cQq+9b1DjNOqoxA8mJXGtCRX yHnG2p/x81itlbYVdkrusOzMRnF0uugbMMYZABJ3Ve6rwE+fhkKb6T8tiwTMDjOcnRG3 sWMH4T9iyvKXoo9VPBzUZmFFjo+rltmSvESnsBhzYRLscgOuR+X0DvH1ko5K0AW3PZ9S 37tDgD3bklbDh1ETS2sIKu79R44O4BTnzcHAyv6kqszB+26pa5+YBlO/dGdeekGctnRg iakA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AomieGoEFlPXySesIE/+tFRPVX7arfEMuDfpcHs3kFg=; b=wEeLcMN9bXj/p4n4GRKpMJV21IbEC/eEpCD0lu2lMp+Ia0vDx79J1ddSwOPXzdqtlL FUr2SSNqDfal00G3o6ojKtN41EJ4rZ5i2sLaEzJvAGaUhXELdzk36vKEBmLPG/14JdD9 J1QDWhxvOXCM1X5rTsAz1Aj0RIGfdoK5CVxA0MAo6utbWSGBZTYw8gHa4qjMZQuHdwpm YapMq2qcoH+5CQInEuvMIJq571eruJ3eKY1jH7C5zP8cOoS7YHkS3uHk3oY6jUUMTxu1 PIKts+9me9SyG4ZyCQvgMcL3PIoSIkNzAj2y8WYjZcERmSB26pGs+9rXw+FGLktaXADs Y8Hg== X-Gm-Message-State: AOAM532wEpULcDhMOEhoDjEtH2rIQQAq09YtTZkgb96ZYECgELvzRcKT MJNAHetGwjg10orfdPZVWW2yYyc5TRR8NQ== X-Google-Smtp-Source: ABdhPJzmshxfOTSnMKCKomkGHaR4e6zE29X9nZ+xP3J6MCcZ1GB3P1xgKBIJCxIJC2HckLsc3XqMRw== X-Received: by 2002:a05:600c:4fd1:: with SMTP id o17mr29290654wmq.110.1634907103607; Fri, 22 Oct 2021 05:51:43 -0700 (PDT) Received: from localhost (host212-140-123-151.range212-140.btcentralplus.com. [212.140.123.151]) by smtp.gmail.com with ESMTPSA id z6sm10405695wmp.1.2021.10.22.05.51.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 05:51:43 -0700 (PDT) Date: Fri, 22 Oct 2021 13:51:42 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH 2/5] gdb/python: new gdb.architecture_names function Message-ID: <20211022125142.GD19507@embecosm.com> References: <837degm731.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <837degm731.fsf@gnu.org> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 13:51:18 up 1 day, 4:25, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2021 12:51:46 -0000 * Eli Zaretskii [2021-10-14 09:52:18 +0300]: > > From: Andrew Burgess > > Date: Wed, 13 Oct 2021 22:59:07 +0100 > > > > Add a new function to the Python API, gdb.architecture_names(). This > > function returns a list containing all of the supported architecture > > names within the current build of GDB. > > > > The values returned in this list are all of the possible values that > > can be returned from gdb.Architecture.name(). > > --- > > gdb/NEWS | 4 +++ > > gdb/doc/python.texi | 9 +++++ > > gdb/python/py-arch.c | 23 +++++++++++++ > > gdb/python/python-internal.h | 1 + > > gdb/python/python.c | 4 +++ > > gdb/testsuite/gdb.python/py-arch.exp | 51 ++++++++++++++++++++++++++++ > > 6 files changed, 92 insertions(+) > > The documentation parts are OK, with a single comment: > > > +string. The names returned in this list are the same names as are > > +returned from @code{gdb.Architecture.name ()} > > +(@pxref{gdbpy_architecture_name,,Architecture.name ()}). > > Please remove "()" from the references to functions and methods. This > usage of "()" to indicate a function is misleading, because it looks > like a call to a function with no arguments, and that's not what you > mean here. Texinfo's markup @code already indicates this is a symbol > and not just a word, so using the parentheses is unnecessary (and > IMNSHO ugly). Thanks, I pushed this patch with the fix you suggested. Andrew