From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 7EF383858421 for ; Mon, 1 Nov 2021 04:07:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7EF383858421 Received: by smtp.gentoo.org (Postfix, from userid 559) id C770B342D75; Mon, 1 Nov 2021 04:07:54 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH] sim: m68hc11: clean up pointer casts Date: Mon, 1 Nov 2021 00:07:54 -0400 Message-Id: <20211101040754.11023-1-vapier@gentoo.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2021 04:07:56 -0000 The void *data field is used to past arbitrary data between event handlers, and these are using it to pass an integer. Fix up the casts to avoid using (long) to cast to/from pointers since there is no guarantee that's the right size. --- sim/m68hc11/dv-m68hc11tim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sim/m68hc11/dv-m68hc11tim.c b/sim/m68hc11/dv-m68hc11tim.c index 2c2e523da11f..08604d314435 100644 --- a/sim/m68hc11/dv-m68hc11tim.c +++ b/sim/m68hc11/dv-m68hc11tim.c @@ -260,7 +260,7 @@ m68hc11tim_timer_event (struct hw *me, void *data) controller = hw_data (me); sd = hw_system (me); cpu = STATE_CPU (sd, 0); - type = (enum event_type) ((long) data) & 0x0FF; + type = (enum event_type) ((uintptr_t) data) & 0x0FF; events = STATE_EVENTS (sd); delay = 0; @@ -280,7 +280,7 @@ m68hc11tim_timer_event (struct hw *me, void *data) eventp = &controller->rti_timer_event; delay = controller->rti_prev_interrupt + controller->rti_delay; - if (((long) (data) & 0x0100) == 0) + if (((uintptr_t) data & 0x0100) == 0) { cpu->ios[M6811_TFLG2] |= M6811_RTIF; check_interrupt = 1; @@ -308,7 +308,7 @@ m68hc11tim_timer_event (struct hw *me, void *data) delay += events->nr_ticks_to_process; eventp = &controller->tof_timer_event; - if (((long) (data) & 0x100) == 0) + if (((uintptr_t) data & 0x100) == 0) { cpu->ios[M6811_TFLG2] |= M6811_TOF; check_interrupt = 1; -- 2.33.0