From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id B4B873858000 for ; Mon, 1 Nov 2021 17:48:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B4B873858000 Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::635]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id BF32C819D4; Mon, 1 Nov 2021 17:48:27 +0000 (UTC) Date: Mon, 1 Nov 2021 17:48:22 +0000 From: Lancelot SIX To: Zoran Zaric Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 04/28] Add to_location method to DWARF entry classes Message-ID: <20211101174822.vbi275e6dvumnden@ubuntu.lan> References: <20211014093235.69756-1-zoran.zaric@amd.com> <20211014093235.69756-5-zoran.zaric@amd.com> <20211022212054.jzoa2vhrdq4pl2yi@ubuntu.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Mon, 01 Nov 2021 17:48:27 +0000 (UTC) X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2021 17:48:30 -0000 On Mon, Nov 01, 2021 at 04:00:02PM +0000, Zoran Zaric via Gdb-patches wrote: > Thank you for reviewing my patch. > > On 10/22/21 10:21 PM, Lancelot SIX wrote: > > [CAUTION: External Email] > > > > Hi, > > > > As for the previous patch, I have included comments and questions > > below. > > > > On Thu, Oct 14, 2021 at 10:32:11AM +0100, Zoran Zaric via Gdb-patches wrote: > > > From: Zoran Zaric > > > > > > DWARF standard already contains an implicit conversion between location > > > description and a DWARF value. In the DWARF 5 version, one place > > > where this can happen is at the very end of the evaluation where a > > > client decides if the result is expected to be in a form of a value or > > > a location description (as_lval argument of the new evaluation method). > > > > > > By allowing any location description to be on the DWARF stack, these > > > implicit conversions are expected on per operation basis which means > > > that the new DWARF entry classes need to have a support for those. > > > > > > This patch adds a conversion method from any DWARF entry object into a > > > location description object. > > > > Reading this, I kind of expect to find the 'to_location' method to be > > defined in dwarf_entry, but it is only created for dwarf_value (the only > > non-dwarf_location-based class). > > > > Reading a bit ahead, I looks like the to_location free function that will > > be introduced in patch 16 of this series ('Change DWARF stack to use new > > dwarf_entry classes') could fit the description. After having a look at > > this function, it looks like it could have been included in this patch > > instead. Was it intended be be included here and somehow slipped in > > another patch? > > I will change the patch notes to say the the method was added to dwarf_value > class and leave the description of the free function to the patch where I > actually add it. > > I can't really add the free function at this point in the series because it > is still not used anywhere and the gdb build system will complain. Indeed, that makes sense. Thanks for the explanation! Lancelot. > > Zoran >