From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6B27C3858C27 for ; Tue, 2 Nov 2021 16:55:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B27C3858C27 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-2v7hbT9KPz6bPTqXI_yZWA-1; Tue, 02 Nov 2021 12:54:59 -0400 X-MC-Unique: 2v7hbT9KPz6bPTqXI_yZWA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CEDEE801B2E; Tue, 2 Nov 2021 16:54:58 +0000 (UTC) Received: from f35-m1 (ovpn-114-255.phx2.redhat.com [10.3.114.255]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9BF8C5D9D3; Tue, 2 Nov 2021 16:54:58 +0000 (UTC) Date: Tue, 2 Nov 2021 09:54:57 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org, Ulrich Weigand , Carl Love Subject: Re: [PATCH][gdb/tdep, rs6000] Don't skip system call in skip_prologue Message-ID: <20211102095457.27ed64cb@f35-m1> In-Reply-To: <20211102113302.GA7990@delia.home> References: <20211102113302.GA7990@delia.home> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2021 16:55:02 -0000 On Tue, 2 Nov 2021 12:33:04 +0100 Tom de Vries wrote: > I ran into a case where a breakpoint on _exit never triggered, because it was > set past the end of the _exit prologue, past the end of the exit_group system > call (which does not return). > > Fix this by treating system calls the same as branches in skip_prologue: > by default, don't skip. LGTM. Kevin