From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lsix@lancelotsix.com>
Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111])
 by sourceware.org (Postfix) with ESMTPS id 064ED3858C27
 for <gdb-patches@sourceware.org>; Tue,  2 Nov 2021 22:51:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 064ED3858C27
Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::635])
 by lndn.lancelotsix.com (Postfix) with ESMTPSA id 45210819D4;
 Tue,  2 Nov 2021 22:51:17 +0000 (UTC)
Date: Tue, 2 Nov 2021 22:51:12 +0000
From: Lancelot SIX <lsix@lancelotsix.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Improve gdb::array_view ctor from contiguous
 containers
Message-ID: <20211102225112.izfzsiwxmopbsb5e@ubuntu.lan>
References: <20211020200525.122108-1-lsix@lancelotsix.com>
 <20211020200525.122108-3-lsix@lancelotsix.com>
 <8acafb4f-ef32-2de8-e71f-8243386b8159@palves.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8acafb4f-ef32-2de8-e71f-8243386b8159@palves.net>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11
 (lndn.lancelotsix.com [0.0.0.0]); Tue, 02 Nov 2021 22:51:17 +0000 (UTC)
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Nov 2021 22:51:20 -0000

Hi,

> Did you look into covering this scenario in unittests/array-view-selftests.c ?

I did not.  I did not check for array-view tests in unittests, my bad.
I’ll look into it shortly and come with a testcase.

Lancelot.