From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2048.outbound.protection.outlook.com [40.107.220.48]) by sourceware.org (Postfix) with ESMTPS id E1B4F3858D35 for ; Fri, 5 Nov 2021 11:39:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E1B4F3858D35 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jyvzr7r3GAPGMne8ly2q4mUP8u4k2fQTrWaTOtg10gl6XiMJ36RBoyQZVciqF3cCVt81e/3fvovTu5ObhADageaVO0+Nu7RM1C6gIsvMKqoyYT8tiDHo6dIZSDt3QBKSgSXyHYTkG7nwdO8h7VM8CnUYTe42nJIcW9V4AXiiD9V8pD74aGNLDnuMfjZDJYnU6gP+DsjLy5wfXsDqod5UaZ6L4zLjXWahgANOb0NpBrtWMvN9CIsPppZqkwpEjn3Db3H9V7Au5rL6jb9iKsPGtuEGFbwXUZsKjCAGTxWaDNdMmUpt7E5KVUNu0rqQ4p775efhyvvcVRoTLiU+463wNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jFAuM12V7FoIQkjRQMR6vXS2ze/ptWBjkTrNPEAPg2c=; b=SRuNVeZwUFu+953gJuTtysBRL05yyQp42RS2gkrdEEoHpcD2glPSGntltLCKux1rX0MiN/0vyzHzLKthttijOS6up5RHuGKL4cMeVCQONWtMI2B/YtuJabIXpCqzUrct9A7WatYUQP+7L/FL7uZ/pwTSxxmD7kGGbIcBr1ovPL/JYFVO2XSErEGDQRQZW7XZen5hc4PcCd37HlMtTU6GpsezSjfv/yz1rL4d5xHgbvjgpC/zr7ak8tAEex/WNaSc/PlL3outDVx0OYOQzozU0qEN+XRbuVhAHfnGKfSzKxILJcqg/GiYsN47YLGjg/6A2m85A/AgXnozzh91krWy2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from MW4PR04CA0178.namprd04.prod.outlook.com (2603:10b6:303:85::33) by CH0PR12MB5387.namprd12.prod.outlook.com (2603:10b6:610:d6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Fri, 5 Nov 2021 11:39:08 +0000 Received: from CO1NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:303:85:cafe::d4) by MW4PR04CA0178.outlook.office365.com (2603:10b6:303:85::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13 via Frontend Transport; Fri, 5 Nov 2021 11:39:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT047.mail.protection.outlook.com (10.13.174.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4669.10 via Frontend Transport; Fri, 5 Nov 2021 11:39:08 +0000 Received: from localhost.localdomain (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Fri, 5 Nov 2021 06:39:06 -0500 From: Zoran Zaric To: Subject: [PATCH v4 01/28] Add new register access interface to expr.c Date: Fri, 5 Nov 2021 11:38:22 +0000 Message-ID: <20211105113849.118800-2-zoran.zaric@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211105113849.118800-1-zoran.zaric@amd.com> References: <20211105113849.118800-1-zoran.zaric@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fdd8978b-cef3-47e8-4ae7-08d9a050e104 X-MS-TrafficTypeDiagnostic: CH0PR12MB5387: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gh1qnjQ7staj3PtL7EP2P0HFb6S6vQ8WKaQXyZuM8n2OrSCkotLWbsHbFcq0K1hLxNNCn9J8cyOWGljxGwRVI789zXGfStX0I9vyrrsn+pDKwLVAEvlqdehyPiLEYGUJEc7Ki8uHI/jCVIFpEEeSy4hQiVmpW/pFVipdgEE9iMZTpncLmt5poRh+o0M1Tc1Tn1sOmx8QMIDOCzeES91b73cR4KLWcaIjxG/jhjXBKvguyouX4ZlG5cz4R4nWoht636yIbraQ74t5Ni15Ppvq8DQWsh5mHDt52AipDYEJB8CXESjrk/vlrRet7TN7c7JDsKrl6TrPAbHSKqj5OS84jtkRRXeDN9ribyFHn7Mtq2fGRWoT28jbpzhaw0W9TKYCAluCE5k1dT0m+4fsHCl9WrL/Dfbyc9lNq/8BzkmPhI4El1f8f5t/fk5tDZcju07h2B4MyVePN2viottLT37E+p+Gw2VNnQSa1ruHZDfWTdLdaAk5grwXv9rFvKpv4oxQzhW8c1Q1QpXqiAuduWohcmlp0kDdvtdDa2le1SFncrkgqaY+Awt5Ra88Pd4BNViVqkuHN9L0E4b8k8an1X2t006JIxQmQ5p2aF7MhKSlSxD75PXvGYhLAcvBzaaO4kSpXq7jkOdig5PSF/Sfe+seesjRsd4+bdbZqVpOhVTtTQ/2R59w6PLxBKZmsm311j8kM3kfOxtAld9zPU4woB7ozu9lVWWZEk+zNkRz7KU3nvU= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(356005)(508600001)(47076005)(8676002)(316002)(1076003)(36860700001)(2616005)(70586007)(81166007)(336012)(6666004)(5660300002)(426003)(6916009)(86362001)(44832011)(186003)(26005)(2906002)(83380400001)(36756003)(70206006)(16526019)(8936002)(4326008)(82310400003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 11:39:08.0909 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fdd8978b-cef3-47e8-4ae7-08d9a050e104 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5387 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2021 11:39:12 -0000 From: Zoran Zaric DWARF expression evaluator is currently using get_frame_register_bytes and put_frame_register_bytes interface for register access. The problem with evaluator using this interface is that it allows a bleed out register access. This means that if the caller specifies a larger amount of data then the size of a specified register, the operation will continue accessing the neighboring registers until a full amount of data has been reached. DWARF specification does not define this behavior, so a new simplified register access interface is needed instead. * dwarf2/expr.c (read_from_register): New function. (write_to_register): New function. (rw_pieced_value): Now calls the read_from_register and write_to_register functions. --- gdb/dwarf2/expr.c | 127 ++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 105 insertions(+), 22 deletions(-) diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index 652161955d5..0ca8528298a 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -99,6 +99,96 @@ read_addr_from_reg (frame_info *frame, int reg) return address_from_register (regnum, frame); } +/* Read register REGNUM's contents in a given FRAME context. + + The data read is offsetted by OFFSET, and the number of bytes read + is defined by LENGTH. The data is then copied into the + caller-managed buffer BUF. + + If the register is optimized out or unavailable for the given + FRAME, the OPTIMIZED and UNAVAILABLE outputs are set + accordingly */ + +static void +read_from_register (frame_info *frame, int regnum, + CORE_ADDR offset, gdb::array_view buf, + int *optimized, int *unavailable) +{ + gdbarch *arch = get_frame_arch (frame); + int regsize = register_size (arch, regnum); + int numregs = gdbarch_num_cooked_regs (arch); + int length = buf.size (); + + /* If a register is wholly inside the OFFSET, skip it. */ + if (frame == NULL || !regsize + || offset + length > regsize || numregs < regnum) + { + *optimized = 0; + *unavailable = 1; + return; + } + + gdb::byte_vector temp_buf (regsize); + enum lval_type lval; + CORE_ADDR address; + int realnum; + + frame_register (frame, regnum, optimized, unavailable, + &lval, &address, &realnum, temp_buf.data ()); + + if (!*optimized && !*unavailable) + memcpy (buf.data (), (char *) temp_buf.data () + offset, length); + + return; +} + +/* Write register REGNUM's contents in a given FRAME context. + + The data written is offsetted by OFFSET, and the number of bytes + written is defined by LENGTH. The data is copied from + caller-managed buffer BUF. + + If the register is optimized out or unavailable for the given + FRAME, the OPTIMIZED and UNAVAILABLE outputs are set + accordingly. */ + +static void +write_to_register (frame_info *frame, int regnum, + CORE_ADDR offset, gdb::array_view buf, + int *optimized, int *unavailable) +{ + gdbarch *arch = get_frame_arch (frame); + int regsize = register_size (arch, regnum); + int numregs = gdbarch_num_cooked_regs (arch); + int length = buf.size (); + + /* If a register is wholly inside of OFFSET, skip it. */ + if (frame == NULL || !regsize + || offset + length > regsize || numregs < regnum) + { + *optimized = 0; + *unavailable = 1; + return; + } + + gdb::byte_vector temp_buf (regsize); + enum lval_type lval; + CORE_ADDR address; + int realnum; + + frame_register (frame, regnum, optimized, unavailable, + &lval, &address, &realnum, temp_buf.data ()); + + if (!*optimized && !*unavailable) + { + memcpy ((char *) temp_buf.data () + offset, buf.data (), length); + + put_frame_register (frame, regnum, temp_buf.data ()); + } + + return; +} + struct piece_closure { /* Reference count. */ @@ -242,24 +332,19 @@ rw_pieced_value (value *v, value *from, bool check_optimized) if (from == nullptr) { /* Read mode. */ - if (!get_frame_register_bytes (frame, gdb_regnum, - bits_to_skip / 8, - buffer, &optim, &unavail)) + read_from_register (frame, gdb_regnum, bits_to_skip / 8, + buffer, &optim, &unavail); + + if (optim) { - if (optim) - { - if (check_optimized) - return true; - mark_value_bits_optimized_out (v, offset, - this_size_bits); - } - if (unavail && !check_optimized) - mark_value_bits_unavailable (v, offset, - this_size_bits); - break; + if (check_optimized) + return true; + mark_value_bits_optimized_out (v, offset, this_size_bits); } - - if (!check_optimized) + if (unavail) + mark_value_bits_unavailable (v, offset, this_size_bits); + /* Only copy data if valid. */ + if (!optim && !unavail && !check_optimized) copy_bitwise (v_contents, offset, buffer.data (), bits_to_skip % 8, this_size_bits, bits_big_endian); @@ -271,9 +356,8 @@ rw_pieced_value (value *v, value *from, bool check_optimized) { /* Data is copied non-byte-aligned into the register. Need some bits from original register value. */ - get_frame_register_bytes (frame, gdb_regnum, - bits_to_skip / 8, - buffer, &optim, &unavail); + read_from_register (frame, gdb_regnum, bits_to_skip / 8, + buffer, &optim, &unavail); if (optim) throw_error (OPTIMIZED_OUT_ERROR, _("Can't do read-modify-write to " @@ -289,9 +373,8 @@ rw_pieced_value (value *v, value *from, bool check_optimized) copy_bitwise (buffer.data (), bits_to_skip % 8, from_contents, offset, this_size_bits, bits_big_endian); - put_frame_register_bytes (frame, gdb_regnum, - bits_to_skip / 8, - buffer); + write_to_register (frame, gdb_regnum, bits_to_skip / 8, + buffer, &optim, &unavail); } } break; -- 2.17.1