From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTPS id 580413857810 for ; Fri, 5 Nov 2021 11:54:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 580413857810 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-291-yE8qS7H5McCYHIFN7SVZGw-1; Fri, 05 Nov 2021 07:54:07 -0400 X-MC-Unique: yE8qS7H5McCYHIFN7SVZGw-1 Received: by mail-wr1-f70.google.com with SMTP id d13-20020adf9b8d000000b00160a94c235aso2251464wrc.2 for ; Fri, 05 Nov 2021 04:54:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qJ4YaJEvClF1JmYc9g4nXPJ3gWgSY1hVIZzjgWMf9XU=; b=ecpxYMENuBBCYOhOXBsDJYsT+DP7gdwED0bpzvr+TGVt6hgeGb7JFwVM61QHnRLi3W wn4gXQ4KTCbThbCp+bLfVLocc7N9JIsxb7cuwmVV1ZMmK1p3Dl4UV81o+IHfDLB506RL GMA2KMuSTQSOAybZ/JLBFqWyXjD+Y9fr4jH/2j/VTl9YMYygCmdo+A45hGI1+0lR6F9O ditHd0tA7l3K7anl6F8oIwSTTOqtCJJn0lNxmlzW+kw+DZ9twhdgPs571uHSgwv2IDVV RsBboSJAOgpKUhx0RJFzapi5hhuC4NyJRzJiixTwZj0rm6QhLOJlHheAvh/GL6izaSTy dTvA== X-Gm-Message-State: AOAM53259+AtdzOtfi3PNkr4peArxw3Vqq9bD27DMs7AkJxUC34Up3ZI 0nEGPNLmQqo1LUeKoHx4jVK7cMOUfQe2L/z3FU5CC+uXP/5TppiYglTvqCnNKhQI6tBrTYnph5y 44mAMuVVp6lSH1qzEXb2dYw== X-Received: by 2002:a05:600c:3ba5:: with SMTP id n37mr13087879wms.168.1636113246039; Fri, 05 Nov 2021 04:54:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxke/iwo07Mp6t2OsSR++bGJ0Qq0T3vvzlqMa3gM87e2xq6nhwPECdBBZAarsM5uWfgAfSXRw== X-Received: by 2002:a05:600c:3ba5:: with SMTP id n37mr13087850wms.168.1636113245764; Fri, 05 Nov 2021 04:54:05 -0700 (PDT) Received: from localhost (host86-166-129-255.range86-166.btcentralplus.com. [86.166.129.255]) by smtp.gmail.com with ESMTPSA id h22sm8740371wmq.14.2021.11.05.04.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Nov 2021 04:54:05 -0700 (PDT) Date: Fri, 5 Nov 2021 11:54:04 +0000 From: Andrew Burgess To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.arch/i386-avx.exp with clang Message-ID: <20211105115404.GA1816063@redhat.com> References: <20211104135559.5875-1-tdevries@suse.de> <20211105093300.GG918204@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 11:50:07 up 4 days, 2:23, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2021 11:54:11 -0000 * Tom de Vries via Gdb-patches [2021-11-05 10:43:38 +0100]: > On 11/5/21 10:33 AM, Andrew Burgess wrote: > > * Tom de Vries via Gdb-patches [2021-11-04 14:55:59 +0100]: > > > >> When running test-case gdb.arch/i386-avx.exp with clang I ran into: > >> ... > >> (gdb) PASS: gdb.arch/i386-avx.exp: set first breakpoint in main > >> continue^M > >> Continuing.^M > >> ^M > >> Program received signal SIGSEGV, Segmentation fault.^M > >> 0x000000000040052b in main (argc=1, argv=0x7fffffffd3c8) at i386-avx.c:54^M > >> 54 asm ("vmovaps 0(%0), %%ymm0\n\t"^M > >> (gdb) FAIL: gdb.arch/i386-avx.exp: continue to breakpoint: \ > >> continue to first breakpoint in main > >> ... > >> > >> The problem is that the vmovaps insn requires an 256-bit (or 32-byte aligned > >> address), and it's only 16-byte aligned: > >> ... > >> (gdb) p /x $rax > >> $1 = 0x601030 > >> ... > >> > >> Fix this by copying to a sufficiently aligned address. > >> > >> Tested on x86_64-linux, with both gcc and clang. > >> --- > >> gdb/testsuite/gdb.arch/i386-avx.c | 28 +++++++++++++++++++++++++++- > >> 1 file changed, 27 insertions(+), 1 deletion(-) > >> > >> diff --git a/gdb/testsuite/gdb.arch/i386-avx.c b/gdb/testsuite/gdb.arch/i386-avx.c > >> index 4e938399a24..9b5323f9f76 100644 > >> --- a/gdb/testsuite/gdb.arch/i386-avx.c > >> +++ b/gdb/testsuite/gdb.arch/i386-avx.c > >> @@ -18,6 +18,9 @@ > >> along with this program. If not, see . */ > >> > >> #include > >> +#include > >> +#include > >> +#include > >> #include "nat/x86-cpuid.h" > >> > >> typedef struct { > >> @@ -25,7 +28,7 @@ typedef struct { > >> } v8sf_t; > >> > >> > >> -v8sf_t data[] = > >> +v8sf_t data_orig[] = > > > > I see the same problem. Did you consider using: > > > > /* Some useful comment .... */ > > v8sf_t data[] __attribute__ ((aligned(32))) = .... > > > > this seems to fix the problem on clang for me, and still works fine > > with gcc. > > I did consider this, and decided against it because it's not > portable. > > Note btw that there is no other usage of this: > ... > $ find gdb/testsuite/ -type f | xargs grep attribute.*align > $ No, but in gdb/testsuite/lib/attribute.h we do setup a compatibility macro for 'noclone', so there's definitely precedent for using attributes that might not be supported everywhere. I'd hope most production level compilers would, if they don't support 'aligned' have something similar/equivalent. Personally, I'd go with a compatibility macro, and let folk who care about other compilers figure out what they need when they hit the problem. But I'm not blocking your proposed solution if you feel strongly about it. Thanks, Andrew > ... > > Btw, I now realize that gdb.arch/i386-sse.exp has the same issue, I'll > try to factor out a solution that can used in both test-cases. > > Thanks, > - Tom