From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lsix@lancelotsix.com>
Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net
 [IPv6:2001:41d0:801:2000::2400])
 by sourceware.org (Postfix) with ESMTPS id 4A5FA3858C2C
 for <gdb-patches@sourceware.org>; Mon,  8 Nov 2021 23:02:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A5FA3858C2C
Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::635])
 by lndn.lancelotsix.com (Postfix) with ESMTPSA id 1718385274
 for <gdb-patches@sourceware.org>; Mon,  8 Nov 2021 23:02:22 +0000 (UTC)
Date: Mon, 8 Nov 2021 23:02:17 +0000
From: Lancelot SIX <lsix@lancelotsix.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/2] Improve gdb::array_view ctor from contiguous
 containers
Message-ID: <20211108230217.sejrgqlvs4ju2c2c@ubuntu.lan>
References: <8acafb4f-ef32-2de8-e71f-8243386b8159@palves.net>
 <20211103222015.50988-1-lsix@lancelotsix.com>
 <df0d8b58-adf6-6d4d-65bf-313192d6db4b@palves.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <df0d8b58-adf6-6d4d-65bf-313192d6db4b@palves.net>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11
 (lndn.lancelotsix.com [0.0.0.0]); Mon, 08 Nov 2021 23:02:22 +0000 (UTC)
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_SBL_CSS, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Nov 2021 23:02:26 -0000

> Alternatively, you could mirror the comment from the built-in array tests:
> 
> /* Check that there's no container->view conversion for containers of derived
>    types or subclasses.  */
> 
> 
> In any case, this is OK.  Thanks for fixing this!

Hi,

I just pushed this.

Lancelot.