From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BC8CA3858D35 for ; Wed, 10 Nov 2021 23:50:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC8CA3858D35 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-unh_3BL5PV20KHGYCLdp-Q-1; Wed, 10 Nov 2021 18:50:09 -0500 X-MC-Unique: unh_3BL5PV20KHGYCLdp-Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6726D101AFA7; Wed, 10 Nov 2021 23:50:08 +0000 (UTC) Received: from f35-m3 (ovpn-114-250.phx2.redhat.com [10.3.114.250]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BA8B5DF5D; Wed, 10 Nov 2021 23:50:08 +0000 (UTC) Date: Wed, 10 Nov 2021 16:50:07 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/testsuite] Add gdb.arch/ppc64-break-on-_exit.exp Message-ID: <20211110165007.18f4fd61@f35-m3> In-Reply-To: <10370dc3-6290-1560-1320-17fbac27409c@suse.de> References: <20211029192419.GA26416@delia> <2cc5e63d-5be1-a5c7-b1cd-6058223a5a19@suse.de> <20211102101329.565a324b@f35-m1> <33a30d8d-247e-fba8-c9f1-b8ff0bd001b2@suse.de> <20211109093517.2d6f07d3@f35-m3> <88bedd77-01f5-a5d3-694e-aa8410113f49@suse.de> <20211109102906.6d2b6e78@f35-m3> <10370dc3-6290-1560-1320-17fbac27409c@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 23:50:11 -0000 On Wed, 10 Nov 2021 11:57:27 +0100 Tom de Vries wrote: > > I think your new test is okay, though (of course) it would have been > > nice to have a test which doesn't depend on particular OS instances. > > Well, how about this one? Does it reproduce for you, also in source > file mode ("if { 1 }" -> "if { 0 }" in the case-case) ? I tried it both ways, using C source, and also using assembler on two different versions of ppc64le Fedora, Fedora 35 and Fedora 32. Testing showed one pass for each of the runs when using builds against recent upstream sources (w/ your fix). When tested against the installed GDB (which does not have your recent ppc related fix), the tests correctly showed 1 failure per run. I like this test better! Kevin