From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 76E0E3858D39 for ; Mon, 15 Nov 2021 06:38:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 76E0E3858D39 Received: by smtp.gentoo.org (Postfix, from userid 559) id EAB5C3431C5; Mon, 15 Nov 2021 06:38:15 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH] sim: bfin: fix mach/xfail usage in tests Date: Mon, 15 Nov 2021 01:38:20 -0500 Message-Id: <20211115063820.20737-1-vapier@gentoo.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 06:38:19 -0000 Set the mach to the right value all the time, and update xfail to say the test fails on all targets. WIth multitarget testing, the idea of target here doesn't make much sense. --- sim/testsuite/bfin/se_all32bitopcodes.S | 4 ++-- sim/testsuite/bfin/se_all64bitg0opcodes.S | 4 ++-- sim/testsuite/bfin/se_illegalcombination.S | 2 +- sim/testsuite/bfin/se_undefinedinstruction3.S | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sim/testsuite/bfin/se_all32bitopcodes.S b/sim/testsuite/bfin/se_all32bitopcodes.S index 6ffe6d1c5cfc..0de8e0de961b 100644 --- a/sim/testsuite/bfin/se_all32bitopcodes.S +++ b/sim/testsuite/bfin/se_all32bitopcodes.S @@ -11,9 +11,9 @@ # Don't want to enable for normal `make check` as it takes way too long in # the sim -- executes over 3 billion insns, and even at 10 MIPS, that's 10+ # minutes. Useful for directed testing, but that's about it. -# mach: none +# mach: bfin # sim: --environment operating -# xfail: too many invalid insns are decoded as valid +# xfail: "too many invalid insns are decoded as valid" *-* #include "test.h" diff --git a/sim/testsuite/bfin/se_all64bitg0opcodes.S b/sim/testsuite/bfin/se_all64bitg0opcodes.S index 516583bb2d3a..72da76b9f30c 100644 --- a/sim/testsuite/bfin/se_all64bitg0opcodes.S +++ b/sim/testsuite/bfin/se_all64bitg0opcodes.S @@ -10,9 +10,9 @@ # Don't want to enable for normal `make check` as it takes way too long in # the sim -- executes over 3 billion insns, and even at 10 MIPS, that's 10+ # minutes. Useful for directed testing, but that's about it. -# mach: none +# mach: bfin # sim: --environment operating -# xfail: too many invalid insns are decoded as valid +# xfail: "too many invalid insns are decoded as valid" *-* #include "test.h" .include "testutils.inc" diff --git a/sim/testsuite/bfin/se_illegalcombination.S b/sim/testsuite/bfin/se_illegalcombination.S index 0fe5f27533ff..85633d1621a0 100644 --- a/sim/testsuite/bfin/se_illegalcombination.S +++ b/sim/testsuite/bfin/se_illegalcombination.S @@ -2,7 +2,7 @@ // Description: Multi-issue Illegal Combinations # mach: bfin # sim: --environment operating -# xfail: "missing a few checks; hardware doesnt seem to match PRM?" bfin-* +# xfail: "missing a few checks; hardware doesnt seem to match PRM?" *-* #include "test.h" .include "testutils.inc" diff --git a/sim/testsuite/bfin/se_undefinedinstruction3.S b/sim/testsuite/bfin/se_undefinedinstruction3.S index 0acfb8888cbc..3db07a8641be 100644 --- a/sim/testsuite/bfin/se_undefinedinstruction3.S +++ b/sim/testsuite/bfin/se_undefinedinstruction3.S @@ -2,7 +2,7 @@ // Description: 32 bit special cases Undefined Instructions in Supervisor Mode # mach: bfin # sim: --environment operating -# xfail: "missing checks in A0/A1 macfunc" bfin-* +# xfail: "missing checks in A0/A1 macfunc" *-* #include "test.h" .include "testutils.inc" -- 2.33.0