Re: [PATCH 2/2] gdb: fix array-view-selftests.c build with g++ 4.8

[Lancelot SIX <lsix@lancelotsix.com>]

On Thu, Nov 18, 2021 at 03:50:53PM -0500, Simon Marchi via Gdb-patches wrote:
> When building with g++ 4.8, I get:
> 
>     CXX    unittests/array-view-selftests.o
>   /home/smarchi/src/binutils-gdb/gdb/unittests/array-view-selftests.c:123:42: error: expected 'class' before 'Container'
>    template<template<typename ...> typename Container>
> 					    ^
> 
> I am no C++ template expert, but it looks like if I change "typename" for
> "class", as the compiler kind of suggests, the code compiles.

Indeed. Apparently 'typename' can be used instead of 'class' in a
template template parameter only starting c++17[1].

Thanks for taking care of this.

Lancelot.

[1] https://en.cppreference.com/w/cpp/language/template_parameters#Template_template_parameter

q> 
> Change-Id: I9c3edd29fb2b190069f0ce0dbf3bc3604d175f48
> ---
>  gdb/unittests/array-view-selftests.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/unittests/array-view-selftests.c b/gdb/unittests/array-view-selftests.c
> index fe211a647b5..9df48db3912 100644
> --- a/gdb/unittests/array-view-selftests.c
> +++ b/gdb/unittests/array-view-selftests.c
> @@ -120,7 +120,7 @@ check ()
>  /* Check that there's no container->view conversion for containers of derived
>     types or subclasses.  */
>  
> -template<template<typename ...> typename Container>
> +template<template<typename ...> class Container>
>  static constexpr bool
>  check_ctor_from_container ()
>  {
> -- 
> 2.33.1
>