From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 25050385C410 for ; Fri, 19 Nov 2021 11:35:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 25050385C410 Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::635]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id AE1A684624; Fri, 19 Nov 2021 11:35:29 +0000 (UTC) Date: Fri, 19 Nov 2021 11:35:24 +0000 From: Lancelot SIX To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] [PR gdb/16238] Add completer for the show user command Message-ID: <20211119113524.22swspch7ry5p322@ubuntu.lan> References: <20211012221330.77493-1-lsix@lancelotsix.com> <351a1a36-6210-cfc4-5815-3070c6f44e7f@polymtl.ca> <20211114154124.cu3cxwtzdmojgzbl@ubuntu.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211114154124.cu3cxwtzdmojgzbl@ubuntu.lan> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Fri, 19 Nov 2021 11:35:29 +0000 (UTC) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2021 11:35:33 -0000 Hi, I do not have the adequate privileges to close the ticket associated with this patch on the bug-tracker. Could someone do it for me? Thanks, Lancelot. On Sun, Nov 14, 2021 at 03:41:24PM +0000, Lancelot SIX via Gdb-patches wrote: > > > > Add curly braces for the outer "if", and the "for" doesn't need them. > > > > Otherwise, this is OK, thanks. > > > > Simon > > Hi, > > Thanks for the review. > > I have fixed the code according to your remark and pushed this commit. > > Best, > Lancelot.