From: Aaron Merey <amerey@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] PR gdb/27876 - debuginfod-downloaded source files don't pass proper fullname across mi / (gdb)info source
Date: Fri, 19 Nov 2021 19:41:40 -0500 [thread overview]
Message-ID: <20211120004140.737744-1-amerey@redhat.com> (raw)
Source files downloaded from debuginfod currently use their original DWARF
filename as their "fullname". This causes a mismatch between the fullname
and the actual location of the source file in the debuginfod client cache.
MI consumers such as VSCode will fail to open debuginfod-downloaded
source files due to this. Also 'info source' will fail to include the
true paths of these files.
To fix this, use the debuginfod cache path as the fullname for debuginfod-
downloaded source files.
---
gdb/debuginfod-support.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c
index 2e1837da949..3f57b5d50cb 100644
--- a/gdb/debuginfod-support.c
+++ b/gdb/debuginfod-support.c
@@ -201,6 +201,7 @@ debuginfod_source_query (const unsigned char *build_id,
if (c == nullptr)
return scoped_fd (-ENOMEM);
+ char *dname = nullptr;
user_data data ("source file", srcpath);
debuginfod_set_user_data (c, &data);
@@ -208,7 +209,7 @@ debuginfod_source_query (const unsigned char *build_id,
build_id,
build_id_len,
srcpath,
- nullptr));
+ &dname));
debuginfod_set_user_data (c, nullptr);
if (debuginfod_verbose > 0 && fd.get () < 0 && fd.get () != -ENOENT)
@@ -217,7 +218,7 @@ debuginfod_source_query (const unsigned char *build_id,
styled_string (file_name_style.style (), srcpath));
if (fd.get () >= 0)
- *destname = make_unique_xstrdup (srcpath);
+ destname->reset (dname);
return fd;
}
--
2.33.1
next reply other threads:[~2021-11-20 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 0:41 Aaron Merey [this message]
2022-01-26 1:43 ` Aaron Merey
2022-02-09 2:30 ` Aaron Merey
2022-03-04 15:32 ` Tom Tromey
2022-03-08 20:50 ` Aaron Merey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211120004140.737744-1-amerey@redhat.com \
--to=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).