From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by sourceware.org (Postfix) with ESMTPS id F08D53858D28 for ; Tue, 23 Nov 2021 15:43:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F08D53858D28 Received: by mail-wr1-f44.google.com with SMTP id v11so1219125wrw.10 for ; Tue, 23 Nov 2021 07:43:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=osXVZtuytAhtPwQ9RpOtxWpRReb1G7nOlfX0YVb6/PA=; b=NaiX/5EJik1Ey8h0NswQNQUIaRu3jmijhg0ED5zE6Gl1WSuBlchLAh9RQfCwYEAhio doaFj3fgb4RCPoQnZlUEdbIa9thkKY8bSsvbAKb5oK9Yr//yp7iqsCYfEmZvSiGkQW9R HoO1qmz4NEq320KZh+EhkF0myrZUGFshsxS5I4u7WOQXWOg5Lgvv4rb75bcdV/KyPbBc HV7+O8lqKVJ7svGutenLzSx7WV+UG3Bn82uDX+DfIYAN+STdpB0xGbGxjCwDHvSmu/BM pnJ3ANPuFxNCn4W1CF7hJPmf+iRpIpNcxI9bymV+VDeuDlezVMFmLGaJkQKQUKEA3f7P dBcA== X-Gm-Message-State: AOAM530popS8JWLDqnCqKkiCzzCcZ3+TpctJeOr+DNnRPrHc6HV8HbyL jFaYYCs8p1idM2to9lPYk5prm90b9as= X-Google-Smtp-Source: ABdhPJx3MaZVWq2YlS0H0FxBEMEsEdwYP4KI19mILKMiMQPnLIjGWUFOjBPyrSA83y7CkmG/iyqh0Q== X-Received: by 2002:a5d:60d0:: with SMTP id x16mr7329997wrt.103.1637682196102; Tue, 23 Nov 2021 07:43:16 -0800 (PST) Received: from localhost ([83.219.56.252]) by smtp.gmail.com with ESMTPSA id b11sm1490987wmj.35.2021.11.23.07.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 07:43:15 -0800 (PST) From: Jan Vrany To: gdb-patches@sourceware.org Cc: Jan Vrany Subject: [PATCH 1/2] ppc: use 'trap' ('tw, 31, 0, 0', 0x7fe00008) as breakpoint instruction Date: Tue, 23 Nov 2021 15:42:36 +0000 Message-Id: <20211123154237.2335848-1-jan.vrany@labware.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 15:43:18 -0000 GDB used to use "tw 12, r2, r2" as a breakpoint instruction. While it works, the PowerPC specifies 'tw, 31, 0, 0' (0x7fe00008) as the canonical unconditional trap. --- gdb/rs6000-tdep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 87a494e0bb8..43880fa4426 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -824,8 +824,8 @@ rs6000_fetch_pointer_argument (struct frame_info *frame, int argi, /* Sequence of bytes for breakpoint instruction. */ -constexpr gdb_byte big_breakpoint[] = { 0x7d, 0x82, 0x10, 0x08 }; -constexpr gdb_byte little_breakpoint[] = { 0x08, 0x10, 0x82, 0x7d }; +constexpr gdb_byte big_breakpoint[] = { 0x7f, 0xe0, 0x00, 0x08 }; +constexpr gdb_byte little_breakpoint[] = { 0x08, 0x00, 0xe0, 0x7f }; typedef BP_MANIPULATION_ENDIAN (little_breakpoint, big_breakpoint) rs6000_breakpoint; -- 2.30.2