From: Lancelot SIX <lsix@lancelotsix.com>
To: Jan Vrany <jan.vrany@labware.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] ppc: recognize all program traps
Date: Wed, 24 Nov 2021 10:57:16 +0000 [thread overview]
Message-ID: <20211124105716.k67xzprypupf2kbz@ubuntu.lan> (raw)
In-Reply-To: <20211124104312.4tclxcwyrvnhgqwv@ubuntu.lan>
> > +
> > +/* Implementation of gdbarch_program_breakpoint_here_p for POWER. */
> > +
> > +static bool
> > +rs6000_program_breakpoint_here_p (gdbarch *gdbarch, CORE_ADDR address)
> > +{
> > + const uint32_t insn_len = 4;
> > + gdb_byte target_mem[4];
>
> You could probably use 'gdb_byte target_mem[insn_len]' here.
Hi again,
Using insn_len here makes most sense if insn_len is also declared
constexpr. So this could become:
constexpr uint32_t insn_len = 4;
gdb_byte target_mem[insn_len];
What do you think?
Best Lancelot.
next prev parent reply other threads:[~2021-11-24 10:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 15:42 [PATCH 1/2] ppc: use 'trap' ('tw, 31, 0, 0', 0x7fe00008) as breakpoint instruction Jan Vrany
2021-11-23 15:42 ` [PATCH 2/2] ppc: recognize all program traps Jan Vrany
2021-11-24 10:43 ` Lancelot SIX
2021-11-24 10:57 ` Lancelot SIX [this message]
2021-11-24 13:09 ` [PATCH v2 0/2] " Jan Vrany
2021-11-24 13:09 ` [PATCH v2 1/2] ppc: use 'trap' ('tw, 31, 0, 0', 0x7fe00008) as breakpoint instruction Jan Vrany
2021-11-27 6:45 ` Joel Brobecker
2021-11-29 11:50 ` Jan Vrany
2021-12-01 9:23 ` Joel Brobecker
2021-11-24 13:09 ` [PATCH v2 2/2] ppc: recognize all program traps Jan Vrany
2021-11-27 6:58 ` Joel Brobecker
2021-11-30 12:17 ` Pedro Alves
2021-12-01 13:52 ` Jan Vrany
2021-12-01 14:30 ` [PATCH v3 0/2] " Jan Vrany
2021-12-01 14:30 ` [PATCH v3 1/2] ppc: use "trap" ("tw, 31, 0, 0") as breakpoint instruction Jan Vrany
2021-12-04 10:16 ` Joel Brobecker
2021-12-01 14:30 ` [PATCH v3 2/2] ppc: recognize all program traps Jan Vrany
2021-12-04 10:18 ` Joel Brobecker
2021-12-07 23:30 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124105716.k67xzprypupf2kbz@ubuntu.lan \
--to=lsix@lancelotsix.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@labware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).