From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by sourceware.org (Postfix) with ESMTPS id 5A4603858C27 for ; Wed, 24 Nov 2021 13:10:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A4603858C27 Received: by mail-wr1-f48.google.com with SMTP id s13so4150125wrb.3 for ; Wed, 24 Nov 2021 05:10:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lQqHYBH+tO12id3IytsUYsf1RW2wXwdaFk/NZUhYvJ8=; b=U7oIra+e6G9BMI7YpcwotC5y6f1EYvLefNZZZP5d/nJ6n+LSe8jqk/qCetuM6en8rw I1llYsBLYdvH/uOCqNeSf0A7nTApes75scGqX5JciooJv0gyyqFh1TTlBT9jc1NJaOjf J0mPXL3iHu3e3J7dgjNefyksFBSpW66iRVd8fjWntcfio+DxH58mgpAD+XZug8LETXeY 4Zaxzp2gRaTpEFj77qSr3GRJLilKXAil0u+iuwKLkQscsTIMESUgRupe0i37EN/V8YLu IvErHL/KhWQgzSgwqgNbGq+Jxgv07mTnFjiGB0kR2czDzE7tUynNVsjrKI2ZGBXoXaoq P/KA== X-Gm-Message-State: AOAM530I/Mkvbyv0j9rra8TvMmAIcguNrVAIMDmvhPDQkZuajP64EO7w MMSHPTIdZJ5nHpUjrN0u8J+QzEqWa+ubMw== X-Google-Smtp-Source: ABdhPJxSyDJiYUoQtYEiTDM8hKhFw0xQ3MIT8lFZuUNuAUb095Ip+eWbSsedaAWh8l59d5wTlsZ4Kg== X-Received: by 2002:a05:6000:1a86:: with SMTP id f6mr18672685wry.230.1637759417285; Wed, 24 Nov 2021 05:10:17 -0800 (PST) Received: from localhost ([83.219.56.252]) by smtp.gmail.com with ESMTPSA id t8sm5507257wmq.32.2021.11.24.05.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 05:10:16 -0800 (PST) From: Jan Vrany To: gdb-patches@sourceware.org Cc: Jan Vrany , lsix@lancelotsix.com Subject: [PATCH v2 0/2] ppc: recognize all program traps Date: Wed, 24 Nov 2021 13:09:24 +0000 Message-Id: <20211124130926.2412617-1-jan.vrany@labware.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211123154237.2335848-1-jan.vrany@labware.com> References: <20211123154237.2335848-1-jan.vrany@labware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 13:10:20 -0000 This new mini-series addresses Lancelot's comments. Changes since v1: * Use already #defined PPC_INSN_SIZE in rs6000_program_breakpoint_here_p(). I decided to use PPC_INSN_SIZE rather than (local) constexpr as suggested to make it consistent with the rest of the code (which uses PPC_INSN_SIZE a lot). * Remove leftover comments from testcases. Jan Vrany (2): ppc: use 'trap' ('tw, 31, 0, 0', 0x7fe00008) as breakpoint instruction ppc: recognize all program traps gdb/rs6000-tdep.c | 69 ++++++++++++++++++++++++- gdb/testsuite/gdb.arch/powerpc-trap.exp | 67 ++++++++++++++++++++++++ gdb/testsuite/gdb.arch/powerpc-trap.s | 30 +++++++++++ gdb/testsuite/gdb.arch/ppc64-trap.exp | 67 ++++++++++++++++++++++++ gdb/testsuite/gdb.arch/ppc64-trap.s | 32 ++++++++++++ 5 files changed, 263 insertions(+), 2 deletions(-) create mode 100644 gdb/testsuite/gdb.arch/powerpc-trap.exp create mode 100644 gdb/testsuite/gdb.arch/powerpc-trap.s create mode 100644 gdb/testsuite/gdb.arch/ppc64-trap.exp create mode 100644 gdb/testsuite/gdb.arch/ppc64-trap.s -- 2.30.2