From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by sourceware.org (Postfix) with ESMTPS id C0DC2385840E for ; Wed, 24 Nov 2021 13:10:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C0DC2385840E Received: by mail-wm1-f51.google.com with SMTP id i8-20020a7bc948000000b0030db7b70b6bso5376815wml.1 for ; Wed, 24 Nov 2021 05:10:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=osXVZtuytAhtPwQ9RpOtxWpRReb1G7nOlfX0YVb6/PA=; b=vxWgwIZNmOlNDRF9D3BEiO5zHmrq+MMGcwc+NfL3yPp7A6DGQC4hv5PiPdjYr68vkw FbICygAERkaKr2seTpU796youEryVLR2yYtvE2+an//ZGUhe2LtAVKgwPwbMrkbXREeX 6DxGKC2fvoPongzw9Ntqn3MKBU+5r/Vjeb/pXSwmNC59xbLGUWmg6Ld/22R1odjvJfY+ g4S+iR9RfoWOEpzAGZK9259AulYB0MACJs0xXjeKV0hHBQtTnpN4NBn09KSXyl/Y5No5 sljL1cTiD9uQxkGxNQ/XTP1wxMFTvEZz5hKvb1NH6g36SU6cUASJ4zozLW9jb9GEEGG5 70TQ== X-Gm-Message-State: AOAM5312pb26JOWB/jy8CaSQUa/XfuGjfWnOS16kWc1ZDFl4S0HubZ9d 7so/oeQ6O9U9DvZgNNutFe2tKkl6O32lPw== X-Google-Smtp-Source: ABdhPJzGf7/GUSsYbWVf07caB1iiyLrzpw7RP61gMEVSSHsy3e0+Mcp00OR6a525d48PH/PL5he4Wg== X-Received: by 2002:a05:600c:2dc8:: with SMTP id e8mr14878390wmh.189.1637759418888; Wed, 24 Nov 2021 05:10:18 -0800 (PST) Received: from localhost ([83.219.56.252]) by smtp.gmail.com with ESMTPSA id j40sm5556573wms.16.2021.11.24.05.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 05:10:18 -0800 (PST) From: Jan Vrany To: gdb-patches@sourceware.org Cc: Jan Vrany , lsix@lancelotsix.com Subject: [PATCH v2 1/2] ppc: use 'trap' ('tw, 31, 0, 0', 0x7fe00008) as breakpoint instruction Date: Wed, 24 Nov 2021 13:09:25 +0000 Message-Id: <20211124130926.2412617-2-jan.vrany@labware.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211124130926.2412617-1-jan.vrany@labware.com> References: <20211123154237.2335848-1-jan.vrany@labware.com> <20211124130926.2412617-1-jan.vrany@labware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 13:10:21 -0000 GDB used to use "tw 12, r2, r2" as a breakpoint instruction. While it works, the PowerPC specifies 'tw, 31, 0, 0' (0x7fe00008) as the canonical unconditional trap. --- gdb/rs6000-tdep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 87a494e0bb8..43880fa4426 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -824,8 +824,8 @@ rs6000_fetch_pointer_argument (struct frame_info *frame, int argi, /* Sequence of bytes for breakpoint instruction. */ -constexpr gdb_byte big_breakpoint[] = { 0x7d, 0x82, 0x10, 0x08 }; -constexpr gdb_byte little_breakpoint[] = { 0x08, 0x10, 0x82, 0x7d }; +constexpr gdb_byte big_breakpoint[] = { 0x7f, 0xe0, 0x00, 0x08 }; +constexpr gdb_byte little_breakpoint[] = { 0x08, 0x00, 0xe0, 0x7f }; typedef BP_MANIPULATION_ENDIAN (little_breakpoint, big_breakpoint) rs6000_breakpoint; -- 2.30.2