From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4CE4A3858C39 for ; Thu, 25 Nov 2021 10:12:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4CE4A3858C39 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-122-4llBMWncOmCXmdLfx-wxKQ-1; Thu, 25 Nov 2021 05:12:44 -0500 X-MC-Unique: 4llBMWncOmCXmdLfx-wxKQ-1 Received: by mail-wm1-f69.google.com with SMTP id n41-20020a05600c502900b003335ab97f41so3230363wmr.3 for ; Thu, 25 Nov 2021 02:12:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r5sngQTarzv1rUvtB1F0VJ83ezKKxeCllzIdgkD8pYY=; b=VUztK0HRVSuytCsTWdjdt4TDxtp/CM9Va4toZJ6JsSt3qnMSWnqO+C+ZNdMA4y1AkQ +rYqX30FFaO++z6Ddkf2TrFA7JkJ1IwZPfbQfVgqgHkso7TdtRmorRSd8PWIFDeoZRAu s6D8bexOlQzS3Zm6frWtAp8AdE3UErlxwmWUua10oZTfkjpiQaFMHo4G0Uoel+hLAy7R KFGvOJO8yVbaNNUBz1Gst8+ZuXCnlyhrrhjc+LOKuxcKpw0SpZZiyT4f5PFb1TMvBFW7 BaMJcZJ21FYwxkJ0XDtZwz4zNJAxsEbARw7cFsS711Yf38rqmJ0doqzQTioaayrFZwlv SuPA== X-Gm-Message-State: AOAM532AqsTSyrV6Q74nLt5WU5J9V9ZmCJ8XKXRukS11RjxXP5OggjNf RPdES8sxB558S09J+j6rLIoPnCSJ0ogFZmpTv3QRvQqeiDboQuV8PH8H9Ii5SRJ/+2XrklafZ/E 7b59JLIlBVluBDRQa4Ka76Q== X-Received: by 2002:a5d:6e01:: with SMTP id h1mr4848479wrz.403.1637835163389; Thu, 25 Nov 2021 02:12:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJyjQyJVOunOS7kh/GCb5FySZTsP6QbJ2PZMcw5d4EUtPIkK6uBXNwCccKhukszrJHtdJyKghA== X-Received: by 2002:a5d:6e01:: with SMTP id h1mr4848462wrz.403.1637835163191; Thu, 25 Nov 2021 02:12:43 -0800 (PST) Received: from localhost (host86-166-129-255.range86-166.btcentralplus.com. [86.166.129.255]) by smtp.gmail.com with ESMTPSA id z7sm7200088wmi.33.2021.11.25.02.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 02:12:42 -0800 (PST) Date: Thu, 25 Nov 2021 10:12:42 +0000 From: Andrew Burgess To: Tom Tromey Cc: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] gdb/python: make some global variables static Message-ID: <20211125101242.GQ2662946@redhat.com> References: <666b1efbde4e68a870a448a921e4c0d3746a8d1b.1635241044.git.andrew.burgess@embecosm.com> <87sfwmnrta.fsf@tromey.com> MIME-Version: 1.0 In-Reply-To: <87sfwmnrta.fsf@tromey.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 10:12:28 up 5 days, 23:11, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Nov 2021 10:12:47 -0000 * Tom Tromey [2021-10-27 14:20:01 -0600]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Make a couple of global variables static in python/python.c. To do > Andrew> this I had to move the definition of extension_language_python to > Andrew> later in the file. > > Andrew> There should be no user visible changes after this commit. > > This looks good to me. Thanks, I've pushed this patch. Andrew