From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9836F3858403 for ; Thu, 25 Nov 2021 10:18:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9836F3858403 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-332-1mDZb8l0MBOZUB4h0wyQbw-1; Thu, 25 Nov 2021 05:17:59 -0500 X-MC-Unique: 1mDZb8l0MBOZUB4h0wyQbw-1 Received: by mail-wm1-f69.google.com with SMTP id j193-20020a1c23ca000000b003306ae8bfb7so2955627wmj.7 for ; Thu, 25 Nov 2021 02:17:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Rp+dKgNJAPx5LbVY8AKNOXlDG0zHakqKY3qB7/G5uP4=; b=jxL9qq3moBphxvUf5o8gHrAQNR2j5hSbZeIWYze9Aj5OEpZeefQ0Qq5JPP0zaQZt5q RMbbwh2K2324NbRNsFQqsp6XWRhSSw0P7FvKWqboqxpuYKCCnUD9Fe43b/gu8Onz22eJ 2snU9fVMqsdcO6mfCnfIuaGBx8n44VZicQOdZrGkyAIEUKzYb88Ayc9CmVS+AK71ISnr V0t6vOgWVeriXJiiHOvwJwKujvjOebw1z+G9grNsXzGK/G+kFAvRi0+wDAjZGwTavp/L 1naEeJBpaGGZA+oFLkzTnT+C5e2LAoCs/L7bHkLFmT53MSKD1kQ3FMz+XHp+zPSc4if/ SXxg== X-Gm-Message-State: AOAM532vIVqUsK0UiL/uFhGwULWU55r46kY04Q9G7q0tdMCnyxayanF8 2Dt6+zDuQqU/a1IGjiZMXtpPinRV8bRGbelmi2AN74PGU4DPd4EBcL6ejUxFDHRqUc+rGfPpZ8H lhdsI1+qYXIXpcCgfXveBlg== X-Received: by 2002:adf:c186:: with SMTP id x6mr5023544wre.580.1637835477651; Thu, 25 Nov 2021 02:17:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJzRBGhQHzzmgwfAr+G/2o1QRlocw5ktgd9ecTH5DSX/z8nezImbZ8f4CrnnUBC9qDGR1xIJRQ== X-Received: by 2002:adf:c186:: with SMTP id x6mr5023521wre.580.1637835477447; Thu, 25 Nov 2021 02:17:57 -0800 (PST) Received: from localhost (host86-166-129-255.range86-166.btcentralplus.com. [86.166.129.255]) by smtp.gmail.com with ESMTPSA id f7sm9360466wmg.6.2021.11.25.02.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 02:17:57 -0800 (PST) Date: Thu, 25 Nov 2021 10:17:56 +0000 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] gdb: rename source_styling_changed observer Message-ID: <20211125101756.GR2662946@redhat.com> References: <33d7cb45d4f4e7d99ef12dbbf2d1606d0aa27d32.1635241044.git.andrew.burgess@embecosm.com> <87o87anrpc.fsf@tromey.com> MIME-Version: 1.0 In-Reply-To: <87o87anrpc.fsf@tromey.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 10:17:03 up 5 days, 23:15, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Nov 2021 10:18:02 -0000 * Tom Tromey [2021-10-27 14:22:23 -0600]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> In the next commit I plan to add disassembler styling. In the same > Andrew> way that we have a source_styling_changed observer I would need to add > Andrew> a disassembler_styling_changed observer. > > Andrew> However, currently, these observers would only be notified from > Andrew> cli-style.c:set_style_enabled, and observed in tui-winsource.c, > Andrew> tui_source_window::style_changed, as a result, having two observers > Andrew> seems unnecessary right now, so, in this commit, I plan to rename > Andrew> source_styling_changed to just styling_changed, then, in the next > Andrew> commit, I can use the same observer for both source styling, and > Andrew> disassembler styling. > > Andrew> There should be no user visible changes after this commit. > > Looks good. It seems to me that the observable was misnamed all along. Thanks. I pushed this patch with a small tweak to the commit message so that I no longer talk about the "next" commit adding disassembler styling. Andrew