From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: [PATCH v3 04/14] linux-nat: Don't enable async mode at the end of linux_nat_target::resume.
Date: Fri, 26 Nov 2021 17:14:43 -0800 [thread overview]
Message-ID: <20211127011453.74487-5-jhb@FreeBSD.org> (raw)
In-Reply-To: <20211127011453.74487-1-jhb@FreeBSD.org>
Commit 5b6d1e4fa4f ("Multi-target support") enabled async mode in the caller
(do_target_resume) after target::resume returns making this call redundant.
Note that there is an earlier call in linux_nat_target::resume. That
call also marks the async event pipe to report an existing event, so
it needs to stay.
---
gdb/linux-nat.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 66664ababf5..b6141e0a3cc 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -1697,9 +1697,6 @@ linux_nat_target::resume (ptid_t ptid, int step, enum gdb_signal signo)
? strsignal (gdb_signal_to_host (signo)) : "0"));
linux_resume_one_lwp (lp, step, signo);
-
- if (target_can_async_p ())
- target_async (1);
}
/* Send a signal to an LWP. */
--
2.33.0
next prev parent reply other threads:[~2021-11-27 1:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 1:14 [PATCH v3 00/14] FreeBSD target async mode and related refactoring John Baldwin
2021-11-27 1:14 ` [PATCH v3 01/14] gdbsupport: Add an event-pipe class John Baldwin
2022-01-14 16:19 ` Tom Tromey
2021-11-27 1:14 ` [PATCH v3 02/14] gdb linux-nat: Convert linux_nat_event_pipe to the event_pipe class John Baldwin
2021-11-27 1:14 ` [PATCH v3 03/14] gdbserver linux-low: Convert linux_event_pipe " John Baldwin
2021-11-27 1:14 ` John Baldwin [this message]
2021-11-27 1:14 ` [PATCH v3 05/14] record: Don't enable async mode at the end of resume target methods John Baldwin
2021-11-27 1:14 ` [PATCH v3 06/14] do_target_wait_1: Clear TARGET_WNOHANG if the target isn't async John Baldwin
2021-11-27 1:14 ` [PATCH v3 07/14] inf-ptrace: Raise an error if waitpid() fails John Baldwin
2021-11-27 1:14 ` [PATCH v3 08/14] inf-ptrace: Support async targets in inf_ptrace_target::wait John Baldwin
2021-11-27 1:14 ` [PATCH v3 09/14] fbsd-nat: Implement async target support John Baldwin
2021-11-27 1:14 ` [PATCH v3 10/14] fbsd-nat: Include ptrace operation in error messages John Baldwin
2021-11-27 1:14 ` [PATCH v3 11/14] fbsd-nat: Various cleanups to the ::resume entry debug message John Baldwin
2021-11-27 1:14 ` [PATCH v3 12/14] fbsd-nat: Return nullptr rather than failing ::thread_name John Baldwin
2021-11-27 1:14 ` [PATCH v3 13/14] Enable async mode in the target in attach_cmd John Baldwin
2021-11-27 1:14 ` [PATCH v3 14/14] inf-ptrace: Add an event_pipe to be used for async mode in subclasses John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211127011453.74487-5-jhb@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).