From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.baldwin.cx (bigwig.baldwin.cx [66.216.25.90]) by sourceware.org (Postfix) with ESMTPS id D4D033858428 for ; Sat, 27 Nov 2021 01:15:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4D033858428 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=FreeBSD.org Received: from gimli.baldwin.net (c-98-35-133-24.hsd1.ca.comcast.net [98.35.133.24]) by mail.baldwin.cx (Postfix) with ESMTPSA id 37A9A1A84C72 for ; Fri, 26 Nov 2021 20:15:04 -0500 (EST) From: John Baldwin To: gdb-patches@sourceware.org Subject: [PATCH v3 04/14] linux-nat: Don't enable async mode at the end of linux_nat_target::resume. Date: Fri, 26 Nov 2021 17:14:43 -0800 Message-Id: <20211127011453.74487-5-jhb@FreeBSD.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211127011453.74487-1-jhb@FreeBSD.org> References: <20211127011453.74487-1-jhb@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (mail.baldwin.cx [0.0.0.0]); Fri, 26 Nov 2021 20:15:04 -0500 (EST) X-Virus-Scanned: clamav-milter 0.103.1 at mail.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_STATUS, KHOP_HELO_FCRDNS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Nov 2021 01:15:06 -0000 Commit 5b6d1e4fa4f ("Multi-target support") enabled async mode in the caller (do_target_resume) after target::resume returns making this call redundant. Note that there is an earlier call in linux_nat_target::resume. That call also marks the async event pipe to report an existing event, so it needs to stay. --- gdb/linux-nat.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index 66664ababf5..b6141e0a3cc 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -1697,9 +1697,6 @@ linux_nat_target::resume (ptid_t ptid, int step, enum gdb_signal signo) ? strsignal (gdb_signal_to_host (signo)) : "0")); linux_resume_one_lwp (lp, step, signo); - - if (target_can_async_p ()) - target_async (1); } /* Send a signal to an LWP. */ -- 2.33.0