From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by sourceware.org (Postfix) with ESMTPS id B9BAB386101E for ; Wed, 1 Dec 2021 14:32:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B9BAB386101E Received: by mail-wr1-f53.google.com with SMTP id d9so31871166wrw.4 for ; Wed, 01 Dec 2021 06:32:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dn/iTA4W4QM5/LlyVk+M8WraXEuSYDbqGzAWMEEljJk=; b=7ofXIRcfmPCwThT6r9No0DZdufd+lWxEsAi9t7hKccEK4L8R37nkNH1Oqf1vDwj2Tm N2QCEyOQ5kepuKWuorOGlGmCsBn/XaTX1El1pnUTWi04TKaQywFC0YQcbUiUwLTNeHvQ q+YCFitzEiYmkSfB+V7pvaIEKSY9sIYmb5ro+WCnCKxxQO8V7doVFaTqdr+I7Z0FROAe aRyeuK4Sy4AMHX8dLm7cfrErBZsVGmrVMAaHy5wx4ekf7rKQkm7uKGWyL2qnUcSyHPAi CXXDr/g1NAmPrOeh06BDSZXaKpCI+Ft8va9KyjlMu+UUGHTxMVJSBbJ0PfQV2hGIicpY YNkw== X-Gm-Message-State: AOAM532VzIgZD6utKk4lXATfjc6v/McLQvF9bdKbXPvWG21xZnwxLJ6G HZhLeyLu1mSgQPA/4FPv1u/7m/7LVAL4rQ== X-Google-Smtp-Source: ABdhPJxYJ39fRYyj8QtnfjVa0V0k2Iwm0uQ+xYtZtfgeyuSJ0fM1fB9/RaHZPPk6xcWEgShdqL9+vg== X-Received: by 2002:a5d:6d8c:: with SMTP id l12mr7075223wrs.435.1638369129910; Wed, 01 Dec 2021 06:32:09 -0800 (PST) Received: from localhost ([83.219.56.252]) by smtp.gmail.com with ESMTPSA id o12sm27890508wrc.85.2021.12.01.06.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 06:32:09 -0800 (PST) From: Jan Vrany To: gdb-patches@sourceware.org Cc: Jan Vrany , lsix@lancelotsix.com, brobecker@adacore.com, pedro@palves.net Subject: [PATCH v3 1/2] ppc: use "trap" ("tw, 31, 0, 0") as breakpoint instruction Date: Wed, 1 Dec 2021 14:30:04 +0000 Message-Id: <20211201143005.3690440-2-jan.vrany@labware.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211124130926.2412617-1-jan.vrany@labware.com> References: <20211124130926.2412617-1-jan.vrany@labware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Dec 2021 14:32:12 -0000 Power ISA 3.0 B spec [1], sections 3.3.11 "Fixed-Point Trap Instructions" and section C.6 "Trap Mnemonics" specify "tw, 31, 0, 0" (encoded as 0x7fe00008) as canonical unconditional trap instruction. This commit changes the breakpoint instruction used by GDB from "tw 12, r2, r2" to unconditional "trap". [1]: https://openpowerfoundation.org/?resource_lib=power-isa-version-3-0 --- gdb/rs6000-tdep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 87a494e0bb8..43880fa4426 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -824,8 +824,8 @@ rs6000_fetch_pointer_argument (struct frame_info *frame, int argi, /* Sequence of bytes for breakpoint instruction. */ -constexpr gdb_byte big_breakpoint[] = { 0x7d, 0x82, 0x10, 0x08 }; -constexpr gdb_byte little_breakpoint[] = { 0x08, 0x10, 0x82, 0x7d }; +constexpr gdb_byte big_breakpoint[] = { 0x7f, 0xe0, 0x00, 0x08 }; +constexpr gdb_byte little_breakpoint[] = { 0x08, 0x00, 0xe0, 0x7f }; typedef BP_MANIPULATION_ENDIAN (little_breakpoint, big_breakpoint) rs6000_breakpoint; -- 2.30.2