From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BE5153858D28 for ; Wed, 15 Dec 2021 13:18:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE5153858D28 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-349-p5ejtiywOrOkurbrHOrYVg-1; Wed, 15 Dec 2021 08:18:16 -0500 X-MC-Unique: p5ejtiywOrOkurbrHOrYVg-1 Received: by mail-wm1-f70.google.com with SMTP id 69-20020a1c0148000000b0033214e5b021so12569431wmb.3 for ; Wed, 15 Dec 2021 05:18:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YgEI7cEaohjKTBxrekej1K91AUteEF6eHmGROo++Jeg=; b=kAK1KNpCKOR6/X4gzD0iS3zXoqbpIBuxlsqvXz/497HgiT2lw9htLDfti9CWkM1CDw zxmL1O3tv7oE8rDafyre4dcsWIcu4OgX+p6egc9CRJ4rHRFQFfN2q5ZbeQdH/vxJPxg0 Q8R9FtHpf74DIaYsMN6KwyCvYt1yKDDF4uPD1Ijs/aMUycKvaBJXkpoCx5aTD4ZnpBGT 3Tsf9nt9eI2JNM8X0TowAQaY57gnfcyBMN+HIGOtxBu4fJFSebRd0A/R+eV0yJct78AA lI73zzhwQZZxlbuC/pPOQuHzhqBz49Hbpu/KgYF2gcO9t/GS9cWnKqbG141XczF/KLpR o7pA== X-Gm-Message-State: AOAM5314YNPzirVllE8330SS+qgPkEpm2lVZQ71K5b9xflENU+awq6cw WuK5mMEHVtkyWTZApsOKma7OnoXDNSwZXULBW8rjAZORCx3RWE3j1unA0ee6JAMCFd2ix3sYJyd d8ecrMK+SrF8LXAkb0EBOAg== X-Received: by 2002:adf:ee05:: with SMTP id y5mr4142744wrn.708.1639574294803; Wed, 15 Dec 2021 05:18:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNNEx53SzIrYACMt1q8/xLL7bLRNDJ4wpEGffxODM3BUDzxqMO9qgBlD25td7TBN5/MIJS7w== X-Received: by 2002:adf:ee05:: with SMTP id y5mr4142728wrn.708.1639574294593; Wed, 15 Dec 2021 05:18:14 -0800 (PST) Received: from localhost (host86-134-238-138.range86-134.btcentralplus.com. [86.134.238.138]) by smtp.gmail.com with ESMTPSA id l15sm1741456wme.47.2021.12.15.05.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 05:18:14 -0800 (PST) Date: Wed, 15 Dec 2021 13:18:13 +0000 From: Andrew Burgess To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Initialize `m_ndimensions' in the member initializer list Message-ID: <20211215131813.GI175541@redhat.com> References: MIME-Version: 1.0 In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 13:17:37 up 2 days, 23:34, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Dec 2021 13:18:25 -0000 * Maciej W. Rozycki [2021-12-11 11:47:06 +0000]: > Following our coding convention initialize the `m_ndimensions' member in > the member initializer list rather than in the body of the constructor > of the `fortran_array_walker' class. No functional change. > --- > gdb/f-array-walker.h | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) LGTM. Thanks, Andrew > > gdb-fortran-array-walker-m-ndimensions-init.diff > Index: src-upstream/gdb/f-array-walker.h > =================================================================== > --- src-upstream.orig/gdb/f-array-walker.h > +++ src-upstream/gdb/f-array-walker.h > @@ -176,10 +176,9 @@ class fortran_array_walker > Args... args) > : m_type (type), > m_address (address), > - m_impl (type, address, args...) > - { > - m_ndimensions = calc_f77_array_dims (m_type); > - } > + m_impl (type, address, args...), > + m_ndimensions (calc_f77_array_dims (m_type)) > + { /* Nothing. */ } > > /* Walk the array. */ > void >