From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH] Avoid crash with cross-linux core file
Date: Wed, 15 Dec 2021 11:33:19 -0700 [thread overview]
Message-ID: <20211215183319.597782-1-tromey@adacore.com> (raw)
An internal test case creates a core file using gcore, then restarts
gdb with that core. When run with a cross-linux gdb (in this case,
x86-64 host with ppc64-linux target), the test fails:
| (gdb) core core
| [New LWP 18437]
| warning: `/lib64/libc.so.6': Shared library architecture unknown is not compatible with target architecture powerpc:common64.
| warning: Could not load shared library symbols for /lib64/ld64.so.1.
| Do you need "set solib-search-path" or "set sysroot"?
| ../../src/gdb/gdbarch.c:3388: internal-error: int gdbarch_elf_make_msymbol_special_p(gdbarch*): Assertion `gdbarch != NULL' failed.
| A problem internal to GDB has been detected,
| further debugging may prove unreliable.
| Quit this debugging session? (y or n) y
What's happening here is that the core file lists some shared
libraries. These aren't available via the solib search path, and so
gdb finds the local (x86-64) libraries. This is not ideal, but on the
other hand, it is what was asked for -- while the test does set
solib-search-path, it does not set the sysroot.
But, because gdb isn't configured to handle these libraries, it
crashes.
It seems to me that it's better to avoid the crash by having
solib_bfd_open fail in the case where a library is incompatible. That
is what this patch does. Now it looks like:
| [New LWP 15488]
| Error while mapping shared library sections:
| `/lib64/libc.so.6': Shared library architecture unknown is not compatible with target architecture powerpc:common64.
... and does not crash gdb.
I don't have a good setup for testing this using dejagnu, so I don't
know whether an existing gdb test covers this scenario.
---
gdb/solib.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/solib.c b/gdb/solib.c
index 3947c2d1d2e..b2205fd245b 100644
--- a/gdb/solib.c
+++ b/gdb/solib.c
@@ -511,10 +511,10 @@ solib_bfd_open (const char *pathname)
/* Check bfd arch. */
b = gdbarch_bfd_arch_info (target_gdbarch ());
if (!b->compatible (b, bfd_get_arch_info (abfd.get ())))
- warning (_("`%s': Shared library architecture %s is not compatible "
- "with target architecture %s."), bfd_get_filename (abfd.get ()),
- bfd_get_arch_info (abfd.get ())->printable_name,
- b->printable_name);
+ error (_("`%s': Shared library architecture %s is not compatible "
+ "with target architecture %s."), bfd_get_filename (abfd.get ()),
+ bfd_get_arch_info (abfd.get ())->printable_name,
+ b->printable_name);
return abfd;
}
--
2.31.1
next reply other threads:[~2021-12-15 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 18:33 Tom Tromey [this message]
2021-12-15 18:39 ` John Baldwin
2022-03-11 16:24 ` Tom Tromey
2022-03-11 16:55 ` John Baldwin
2022-03-11 18:52 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215183319.597782-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).