public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] Change how stdlog timestamps are written
Date: Fri, 31 Dec 2021 13:18:57 -0700	[thread overview]
Message-ID: <20211231201901.1567610-1-tom@tromey.com> (raw)

I've been looking at the GDB ui_file and pager system to see if it can
be made more understandable -- right now it's fairly spaghetti-ish,
with ui_file calling into functions in util.c, that then dispatch back
to ui_file.  My vision for the endpoint is something along the lines
of Java's stream writers, where additional functionality is provided
by just instantiating some new writer to wrap an existing one.

This series is a step toward that long-term goal.  It changes how
gdb_stdlog timestamps are written, moving this into a new ui_file
subclass.  This avoids a special case (which may in some situations be
incorrect, see patch #4) in vfprintf_unfiltered.

Regression tested on x86-64 Fedora 34.

Let me know what you think.

Tom



             reply	other threads:[~2021-12-31 20:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-31 20:18 Tom Tromey [this message]
2021-12-31 20:18 ` [PATCH 1/4] Simplify the CLI set_logging logic Tom Tromey
2021-12-31 20:18 ` [PATCH 2/4] Use unique_ptr in CLI logging code Tom Tromey
2021-12-31 20:19 ` [PATCH 3/4] Add new timestamped_file class Tom Tromey
2021-12-31 20:19 ` [PATCH 4/4] Switch gdb_stdlog to use timestamped_file Tom Tromey
2022-03-24 16:21 ` [PATCH 0/4] Change how stdlog timestamps are written Tom Tromey
2022-03-28 20:12   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211231201901.1567610-1-tom@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).