From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id D1CC73858D28 for ; Sat, 1 Jan 2022 17:55:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D1CC73858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 3EB2B1004BA17 for ; Sat, 1 Jan 2022 17:55:23 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 3ibCn3KLOEaNC3ibDnvEfB; Sat, 01 Jan 2022 17:55:23 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=dJtjJMVb c=1 sm=1 tr=0 ts=61d0958b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=I07Vin2HtaSM_UKgdIMA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MdOpb+gnz1YtELE/4y+Z1G5BeDyYjOI0e4RNL/11toA=; b=SJopKBKG11rbjpS5aSwQkugS9d VLM/KgxVJqmBHBTQcqbFw2UPoChy2s++Cd83qWf4K6RrGfZxL4KjCzRGz1HmOkEtHEzoT+3DJo3bs 51/XI2iSMUvYhJLKUBFISiWua; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:52052 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n3ibC-0034re-Gz for gdb-patches@sourceware.org; Sat, 01 Jan 2022 10:55:22 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 00/12] More filtered output cleanups Date: Sat, 1 Jan 2022 10:55:08 -0700 Message-Id: <20220101175520.351628-1-tom@tromey.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n3ibC-0034re-Gz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (localhost.localdomain) [75.166.134.30]:52052 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jan 2022 17:55:26 -0000 I found a number of places that use unfiltered output, but that probably ought to use filtered output. This patch fixes nearly all of them (I'll send the remaining patches separately). The default for user commands should always be to use filtered output. This way, users will get the correct paging behavior. And, because the filter only applies to gdb_stdout anyway, it's safest to use the _filtered forms in most places. In the longer run, I think it would be best to reimplement the pager directly in the gdb_stdout ui_file. That way, almost no code will need to make the filtered/unfiltered distinction -- it will be done by choice of stream. I'm working on some patches toward this goal. This series is a useful step toward that, and IMO desirable on its own as well. Regression tested on x86-64 Fedora 34. Tom