From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 75AAD3858C27 for ; Sat, 1 Jan 2022 17:55:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 75AAD3858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id E30FC10044B89 for ; Sat, 1 Jan 2022 17:55:26 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 3ibGnEa0rXOyf3ibGnAB0d; Sat, 01 Jan 2022 17:55:26 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ot6Kdwzt c=1 sm=1 tr=0 ts=61d0958e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=1zrDrJQfS-NY1tJcr2IA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PU6/tY7PjfS0XCBxUBecNSYDGOqXvD7sMZIY62S/NQY=; b=TK1rids/R/cKg5SaoLz6oO1tQo P1JK3hZVa9QSIaPVSuA+99jDSXnXIRR/ORtaiDRPbtGEPCkhJ+7rJeJIMYy77fPTpWtqmCzfafNOT nR310r7+QhMDB1Ef9mRNEh6Kd; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:52052 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n3ibG-0034re-6a; Sat, 01 Jan 2022 10:55:26 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 09/12] Use filtered output in *-tdep commands Date: Sat, 1 Jan 2022 10:55:17 -0700 Message-Id: <20220101175520.351628-10-tom@tromey.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220101175520.351628-1-tom@tromey.com> References: <20220101175520.351628-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n3ibG-0034re-6a X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (localhost.localdomain) [75.166.134.30]:52052 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_BL, RCVD_IN_MSPIKE_L3, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jan 2022 17:55:28 -0000 Various targets introduce their own commands, which then use unfiltered output. It's better to use filtered output by default, so this patch fixes the instances I found. --- gdb/avr-tdep.c | 2 +- gdb/hppa-tdep.c | 30 +++++++++++++++--------------- gdb/i386-tdep.c | 6 +++--- gdb/mips-tdep.c | 6 +++--- gdb/s12z-tdep.c | 2 +- 5 files changed, 23 insertions(+), 23 deletions(-) diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c index 9ead25d5386..7f79ef94bdf 100644 --- a/gdb/avr-tdep.c +++ b/gdb/avr-tdep.c @@ -1589,7 +1589,7 @@ avr_io_reg_read_command (const char *args, int from_tty) return; } - printf_unfiltered (_("Target has %u io registers:\n\n"), nreg); + printf_filtered (_("Target has %u io registers:\n\n"), nreg); /* only fetch up to 8 registers at a time to keep the buffer small */ int step = 8; diff --git a/gdb/hppa-tdep.c b/gdb/hppa-tdep.c index 6c6e538e822..32c54357045 100644 --- a/gdb/hppa-tdep.c +++ b/gdb/hppa-tdep.c @@ -2572,19 +2572,19 @@ unwind_command (const char *exp, int from_tty) if (!u) { - printf_unfiltered ("Can't find unwind table entry for %s\n", exp); + printf_filtered ("Can't find unwind table entry for %s\n", exp); return; } - printf_unfiltered ("unwind_table_entry (%s):\n", host_address_to_string (u)); + printf_filtered ("unwind_table_entry (%s):\n", host_address_to_string (u)); - printf_unfiltered ("\tregion_start = %s\n", hex_string (u->region_start)); + printf_filtered ("\tregion_start = %s\n", hex_string (u->region_start)); - printf_unfiltered ("\tregion_end = %s\n", hex_string (u->region_end)); + printf_filtered ("\tregion_end = %s\n", hex_string (u->region_end)); -#define pif(FLD) if (u->FLD) printf_unfiltered (" "#FLD); +#define pif(FLD) if (u->FLD) printf_filtered (" "#FLD); - printf_unfiltered ("\n\tflags ="); + printf_filtered ("\n\tflags ="); pif (Cannot_unwind); pif (Millicode); pif (Millicode_save_sr0); @@ -2609,9 +2609,9 @@ unwind_command (const char *exp, int from_tty) pif (Large_frame); pif (alloca_frame); - putchar_unfiltered ('\n'); + putchar_filtered ('\n'); -#define pin(FLD) printf_unfiltered ("\t"#FLD" = 0x%x\n", u->FLD); +#define pin(FLD) printf_filtered ("\t"#FLD" = 0x%x\n", u->FLD); pin (Region_description); pin (Entry_FR); @@ -2620,26 +2620,26 @@ unwind_command (const char *exp, int from_tty) if (u->stub_unwind.stub_type) { - printf_unfiltered ("\tstub type = "); + printf_filtered ("\tstub type = "); switch (u->stub_unwind.stub_type) { case LONG_BRANCH: - printf_unfiltered ("long branch\n"); + printf_filtered ("long branch\n"); break; case PARAMETER_RELOCATION: - printf_unfiltered ("parameter relocation\n"); + printf_filtered ("parameter relocation\n"); break; case EXPORT: - printf_unfiltered ("export\n"); + printf_filtered ("export\n"); break; case IMPORT: - printf_unfiltered ("import\n"); + printf_filtered ("import\n"); break; case IMPORT_SHLIB: - printf_unfiltered ("import shlib\n"); + printf_filtered ("import shlib\n"); break; default: - printf_unfiltered ("unknown (%d)\n", u->stub_unwind.stub_type); + printf_filtered ("unknown (%d)\n", u->stub_unwind.stub_type); } } } diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index 6d8a43fb4f8..aaa5592f40a 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -8992,14 +8992,14 @@ i386_mpx_info_bounds (const char *args, int from_tty) if (gdbarch_bfd_arch_info (gdbarch)->arch != bfd_arch_i386 || !i386_mpx_enabled ()) { - printf_unfiltered (_("Intel Memory Protection Extensions not " - "supported on this target.\n")); + printf_filtered (_("Intel Memory Protection Extensions not " + "supported on this target.\n")); return; } if (args == NULL) { - printf_unfiltered (_("Address of pointer variable expected.\n")); + printf_filtered (_("Address of pointer variable expected.\n")); return; } diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c index 7f8018360dd..e5f8c6b2053 100644 --- a/gdb/mips-tdep.c +++ b/gdb/mips-tdep.c @@ -6916,7 +6916,7 @@ show_mipsfpu_command (const char *args, int from_tty) if (gdbarch_bfd_arch_info (target_gdbarch ())->arch != bfd_arch_mips) { - printf_unfiltered + printf_filtered ("The MIPS floating-point coprocessor is unknown " "because the current architecture is not MIPS.\n"); return; @@ -6937,11 +6937,11 @@ show_mipsfpu_command (const char *args, int from_tty) internal_error (__FILE__, __LINE__, _("bad switch")); } if (mips_fpu_type_auto) - printf_unfiltered ("The MIPS floating-point coprocessor " + printf_filtered ("The MIPS floating-point coprocessor " "is set automatically (currently %s)\n", fpu); else - printf_unfiltered + printf_filtered ("The MIPS floating-point coprocessor is assumed to be %s\n", fpu); } diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c index 24ebc6a8516..3f9740f0dfe 100644 --- a/gdb/s12z-tdep.c +++ b/gdb/s12z-tdep.c @@ -635,7 +635,7 @@ show_bdccsr_command (const char *args, int from_tty) struct string_file output; target_rcmd ("bdccsr", &output); - printf_unfiltered ("The current BDCCSR value is %s\n", output.string().c_str()); + printf_filtered ("The current BDCCSR value is %s\n", output.string().c_str()); } static struct gdbarch * -- 2.31.1