From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by sourceware.org (Postfix) with ESMTPS id 6A5AB3858410 for ; Tue, 4 Jan 2022 17:23:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6A5AB3858410 Received: by mail-qk1-x734.google.com with SMTP id 69so35543663qkd.6 for ; Tue, 04 Jan 2022 09:23:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/t5mBONl79k1y3L9BW0yByBxydkuhJrryzxSvdO0VMM=; b=zxkLS2ObQYwLv967bok84P6gDx/wRJiMPv3rvhchtIxCqPn3Rk0w2EoyNz4UA8+Jb8 qUgDPFO4ycv/dr0Gcyu100zgq/FZKZLf4aFXlaFHimQMx2wZrc9JNl2tbHd4FzEu5UIF ov+41oFeQRM29nFCwTrt1cyuvoGB1OOjEKdl8npk0iFOHV1rH1T/rA+fK9A/aqwPjyMm iqut8jWw7Crin4xF0CaqDqlXgPBs5oAnXgHo+kFbjvReYl58lS470Pwx77+1tHXzWJ0c 8GR422yw1tgj5rh+V6zD7waLTh7ASMXVJBrvAiNGARRJPxmQ2zQOJ5bco8tk851CDEVo zbxw== X-Gm-Message-State: AOAM531A6WowUZm4zmL+x9GI4iQVUO5w7Vh/bdrcs31CS1sqvuDCkGVh efgS6lk2FfPgO8XaOMVYVzI+pAlZ7BLo+Q== X-Google-Smtp-Source: ABdhPJz6hITi6ou0SkjPBclhO0d9mbXVwQDWeyc95FicY/p9NFPH4bDZ8P+psFe2Msopd6FikEYycg== X-Received: by 2002:a05:620a:2544:: with SMTP id s4mr35891852qko.128.1641316982023; Tue, 04 Jan 2022 09:23:02 -0800 (PST) Received: from localhost.localdomain ([2804:7f0:4841:563b:d924:ff26:cde9:15a7]) by smtp.gmail.com with ESMTPSA id o9sm33435831qtk.81.2022.01.04.09.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 09:23:01 -0800 (PST) From: Luis Machado To: gdb-patches@sourceware.org Subject: [PATCH] [AArch64] Fix PR gdb/28681 Date: Tue, 4 Jan 2022 14:22:54 -0300 Message-Id: <20220104172254.3665546-1-luis.machado@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 17:23:03 -0000 This is the same as commit b1718fcdd1d2a5c514f8ee504ba07fb3f42b8608, but fixing things for AArch64. With the patch, gdb.cp/non-trivial-retval.exp has full passes on AArch64-Linux Ubuntu 20.04/18.04. --- gdb/aarch64-tdep.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 70fb66954a4..802762f303c 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -2323,6 +2323,15 @@ aarch64_extract_return_value (struct type *type, struct regcache *regs, valbuf += X_REGISTER_SIZE; } } + else if (!language_pass_by_reference (type).trivially_copyable) + { + /* If the object is a non-trivial C++ object, the result is passed as a + pointer stored in X0. */ + CORE_ADDR addr; + + regs->cooked_read (AARCH64_X0_REGNUM, &addr); + read_memory (addr, valbuf, TYPE_LENGTH (type)); + } else { /* For a structure or union the behaviour is as if the value had -- 2.25.1