From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id ACAC63951C74 for ; Thu, 13 Jan 2022 15:22:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACAC63951C74 X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="307372844" X-IronPort-AV: E=Sophos;i="5.88,286,1635231600"; d="scan'208";a="307372844" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 07:21:38 -0800 X-IronPort-AV: E=Sophos;i="5.88,286,1635231600"; d="scan'208";a="670541902" Received: from labpc2315.iul.intel.com (HELO localhost) ([172.28.50.57]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 07:21:34 -0800 From: Christina Schimpe To: gdb-patches@sourceware.org Subject: [PATCH 0/3] Apply fixme notes for multi-target support Date: Thu, 13 Jan 2022 16:21:15 +0100 Message-Id: <20220113152118.1465255-1-christina.schimpe@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jan 2022 15:22:24 -0000 Hi all, this is a set of patches that apply the fixme notes described in commit 5b6d1e4 "Multi-target support". "You'll notice that remote.c includes some FIXME notes. These refer to the fact that the global arrays that hold data for the remote packets supported are still globals. For example, if we connect to two different servers/stubs, then each might support different remote protocol features. They might even be different architectures, like e.g., one ARM baremetal stub, and a x86 gdbserver, to debug a host/controller scenario as a single program. That isn't going to work correctly today, because of said globals. I'm leaving fixing that for another pass, since it does not appear to be trivial, and I'd rather land the base work first. It's already useful to be able to debug multiple instances of the same server (e.g., a distributed cluster, where you have full control over the servers installed), so I think as is it's already reasonable incremental progress." Due to the global array and variables used by all remote targets, the command line configuration for remote targets' features before this set of patches affected existing remote targets and future remote targets. It was not possible to individually configure a remote target's feature. This behavior is now different. With this patch series, the currently selected remote target's as well as a future remote target's feature set can be configured, without affecting the feature sets of the existing remote targets. Any feedback about this series of patches is appreciated. Regards, Christina Christina Schimpe (3): gdb: Make global feature array a per-remote target array gdb: Add per-remote target variables for memory read and write config gdb: Remove workaround for the vCont packet gdb/remote.c | 1004 +++++++++-------- gdb/testsuite/gdb.base/remote.exp | 7 +- .../gdb.multi/multi-target-info-inferiors.exp | 6 +- gdb/testsuite/gdb.multi/multi-target.exp.tcl | 7 +- 4 files changed, 570 insertions(+), 454 deletions(-) -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928