From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by sourceware.org (Postfix) with ESMTPS id 44D273858402 for ; Mon, 17 Jan 2022 08:50:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 44D273858402 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20H74IrL003347 for ; Mon, 17 Jan 2022 09:50:03 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3dmq5g39aw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 17 Jan 2022 09:50:03 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BEEC910003B for ; Mon, 17 Jan 2022 09:50:02 +0100 (CET) Received: from Webmail-eu.st.com (gpxdag2node5.st.com [10.75.127.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 76C3620ED31 for ; Mon, 17 Jan 2022 09:50:02 +0100 (CET) Received: from gnx2104.gnb.st.com (10.75.127.49) by GPXDAG2NODE5.st.com (10.75.127.69) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Mon, 17 Jan 2022 09:50:02 +0100 From: Christophe Lyon To: CC: , Christophe Lyon Subject: [PATCH 1/5] gdb/arm: Fix prologue analysis to support vpush Date: Mon, 17 Jan 2022 09:49:20 +0100 Message-ID: <20220117084944.3506-1-christophe.lyon@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To GPXDAG2NODE5.st.com (10.75.127.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-17_02,2022-01-14_01,2021-12-02_01 X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2022 08:50:07 -0000 [re-sent with the right cc: address] While working on adding support for Non-secure/Secure modes unwinding, I noticed that the prologue analysis lacked support for vpush, which is used for instance in the CMSE stub routine. This patch updates thumb_analyze_prologue accordingly. --- gdb/arm-tdep.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 7495434484e..14ec0bc8f9e 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -896,6 +896,27 @@ thumb_analyze_prologue (struct gdbarch *gdbarch, regs[bits (insn, 0, 3)] = addr; } + else if ((insn & 0xff20) == 0xed20 /* vstmdb Rn{!}, + { registers } */ + && pv_is_register (regs[bits (insn, 0, 3)], ARM_SP_REGNUM)) + { + pv_t addr = regs[bits (insn, 0, 3)]; + int number = bits (inst2, 0, 7) >> 1; + + if (stack.store_would_trash (addr)) + break; + + /* Calculate offsets of saved registers. */ + for (; number > 0; number--) + { + addr = pv_add_constant (addr, -8); + stack.store (addr, 8, pv_register (ARM_D0_REGNUM + number, 0)); + } + + if (insn & 0x0020) + regs[bits (insn, 0, 3)] = addr; + } + else if ((insn & 0xff50) == 0xe940 /* strd Rt, Rt2, [Rn, #+/-imm]{!} */ && pv_is_register (regs[bits (insn, 0, 3)], ARM_SP_REGNUM)) -- 2.25.1