From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 543F3385801E for ; Tue, 18 Jan 2022 19:40:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 543F3385801E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id B6FB410041510 for ; Tue, 18 Jan 2022 19:40:10 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 9uKwnus0xwm8i9uKwntQZ3; Tue, 18 Jan 2022 19:40:10 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DpSTREz+ c=1 sm=1 tr=0 ts=61e7179a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=HDSJ-0RCBE1wrngNvFsA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Y/3VCSqJhueFwtE6Wb5MNfHDiiMgs4StX+IjdSVVCzY=; b=Jblht8U7z1PngkrDmjjZ86J0G5 T4iRhURl5rfoAx01G8WDL3p9zbQ0/f6Ue2KxpE7554fl+J0sriv5IjFuHWupneEf6MtU+IHSemHQt /AhK0pxHDibyUaaWaXG+tjx+O; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:40582 helo=prentzel.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9uKv-0015NP-S9 for gdb-patches@sourceware.org; Tue, 18 Jan 2022 12:40:09 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 00/36] C++-ify breakpoints Date: Tue, 18 Jan 2022 12:39:31 -0700 Message-Id: <20220118194007.2853108-1-tom@tromey.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n9uKv-0015NP-S9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (prentzel.Home) [75.166.134.30]:40582 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 19:40:13 -0000 This series somewhat C++-ifies breakpoints. It turns most breakpoint_ops function pointers into virtual methods, and introduces a class hierarchy for breakpoints. The series starts with a few minor cleanups and clarifications. Then it introduces a new vtable-based breakpoint_ops structure. This is used to convert breakpoint types one-by-one, to avoid having a monster patch. Then, near the end, this is removed again and some final cleanups applied. I built and regression tested each patch in this series on x86-64 Fedora 34. There is still more work that could be done to improve this code in the future: * Right now, if you want to add a new breakpoint type, you may need a new bptype enumerator constant. However, these can be a pain to add. I think it would be better to remove this enum entirely, in favor of ordinary object-oriented techniques like methods. Similarly, perhaps create_breakpoint could be replaced with constructors. * breakpoint_ops isn't fully removed, as it has a couple of "static virtual" methods -- methods that vary by breakpoint type, but which can't be methods on the breakpoint itself. This could probably be fixed somehow. * I left the base class name as "breakpoint" to avoid rewriting a lot of code. However, this isn't really the best name, so this could be changed. * Some methods on the base class could probably be made pure virtual. This is currently faked, following the approach already used in the source: the methods abort when called. Changing this to use the real C++ feature would be an improvement. * Relatedly, some members of 'breakpoint' could be pushed into the relevant subclasses. For example, breakpoint::location_range_end is only used by ranged breakpoints, and so could be moved to struct ranged_breakpoint. This same idea probably applies to some methods as well. Tom