From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id D68CC3857C76 for ; Tue, 18 Jan 2022 19:40:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D68CC3857C76 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 4E07C10047579 for ; Tue, 18 Jan 2022 19:40:14 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 9uKznA7donAlU9uL0n1WPJ; Tue, 18 Jan 2022 19:40:14 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QIOt+iHL c=1 sm=1 tr=0 ts=61e7179e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=foluJ0pwmSnNOyCsKE0A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lWK2tgG4IoaZswC15C9o5rugbYJ9sXkvt7XEIESTkTo=; b=NSXAaYYO819rogE8A+DBorIrZD kxPSFP8tdcYzwz7m+9GfFr6UctChn0hF4D/XDev0GTM4m4C46jtXGlSbiVcqbeyFcKIx3Jzn4SXNm TprXTsn8ecYhZc5mcD22xBv5C; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:40584 helo=prentzel.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9uKz-0015TE-KC; Tue, 18 Jan 2022 12:40:13 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 10/36] Convert break-catch-fork to vtable ops Date: Tue, 18 Jan 2022 12:39:41 -0700 Message-Id: <20220118194007.2853108-11-tom@tromey.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220118194007.2853108-1-tom@tromey.com> References: <20220118194007.2853108-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n9uKz-0015TE-KC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (prentzel.Home) [75.166.134.30]:40584 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3031.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 19:40:16 -0000 This converts break-catch-fork.c to use vtable_breakpoint_ops. --- gdb/break-catch-fork.c | 142 ++++++++++++++++------------------------- 1 file changed, 56 insertions(+), 86 deletions(-) diff --git a/gdb/break-catch-fork.c b/gdb/break-catch-fork.c index 8877099e013..9b3721a605e 100644 --- a/gdb/break-catch-fork.c +++ b/gdb/break-catch-fork.c @@ -34,6 +34,18 @@ struct fork_catchpoint : public breakpoint { + int insert_location (struct bp_location *) override; + int remove_location (struct bp_location *, + enum remove_bp_reason reason) override; + int breakpoint_hit (const struct bp_location *bl, + const address_space *aspace, + CORE_ADDR bp_addr, + const target_waitstatus &ws) override; + enum print_stop_action print_it (struct bpstat *bs) override; + bool print_one (struct bp_location **) override; + void print_mention () override; + void print_recreate (struct ui_file *fp) override; + /* True if the breakpoint is for vfork, false for fork. */ bool is_vfork; @@ -43,94 +55,82 @@ struct fork_catchpoint : public breakpoint ptid_t forked_inferior_pid; }; -/* Implement the "insert" breakpoint_ops method for fork - catchpoints. */ +/* Implement the "insert" method for fork catchpoints. */ -static int -insert_catch_fork (struct bp_location *bl) +int +fork_catchpoint::insert_location (struct bp_location *bl) { - struct fork_catchpoint *c = (struct fork_catchpoint *) bl->owner; - - if (c->is_vfork) + if (is_vfork) return target_insert_vfork_catchpoint (inferior_ptid.pid ()); else return target_insert_fork_catchpoint (inferior_ptid.pid ()); } -/* Implement the "remove" breakpoint_ops method for fork - catchpoints. */ +/* Implement the "remove" method for fork catchpoints. */ -static int -remove_catch_fork (struct bp_location *bl, enum remove_bp_reason reason) +int +fork_catchpoint::remove_location (struct bp_location *bl, + enum remove_bp_reason reason) { - struct fork_catchpoint *c = (struct fork_catchpoint *) bl->owner; - - if (c->is_vfork) + if (is_vfork) return target_remove_vfork_catchpoint (inferior_ptid.pid ()); else return target_remove_fork_catchpoint (inferior_ptid.pid ()); } -/* Implement the "breakpoint_hit" breakpoint_ops method for fork - catchpoints. */ +/* Implement the "breakpoint_hit" method for fork catchpoints. */ -static int -breakpoint_hit_catch_fork (const struct bp_location *bl, - const address_space *aspace, CORE_ADDR bp_addr, - const target_waitstatus &ws) +int +fork_catchpoint::breakpoint_hit (const struct bp_location *bl, + const address_space *aspace, + CORE_ADDR bp_addr, + const target_waitstatus &ws) { - struct fork_catchpoint *c = (struct fork_catchpoint *) bl->owner; - - if (ws.kind () != (c->is_vfork + if (ws.kind () != (is_vfork ? TARGET_WAITKIND_VFORKED : TARGET_WAITKIND_FORKED)) return 0; - c->forked_inferior_pid = ws.child_ptid (); + forked_inferior_pid = ws.child_ptid (); return 1; } -/* Implement the "print_it" breakpoint_ops method for fork - catchpoints. */ +/* Implement the "print_it" method for fork catchpoints. */ -static enum print_stop_action -print_it_catch_fork (bpstat *bs) +enum print_stop_action +fork_catchpoint::print_it (bpstat *bs) { struct ui_out *uiout = current_uiout; - struct breakpoint *b = bs->breakpoint_at; - struct fork_catchpoint *c = (struct fork_catchpoint *) bs->breakpoint_at; - annotate_catchpoint (b->number); + annotate_catchpoint (number); maybe_print_thread_hit_breakpoint (uiout); - if (b->disposition == disp_del) + if (disposition == disp_del) uiout->text ("Temporary catchpoint "); else uiout->text ("Catchpoint "); if (uiout->is_mi_like_p ()) { uiout->field_string ("reason", - async_reason_lookup (c->is_vfork + async_reason_lookup (is_vfork ? EXEC_ASYNC_VFORK : EXEC_ASYNC_FORK)); - uiout->field_string ("disp", bpdisp_text (b->disposition)); + uiout->field_string ("disp", bpdisp_text (disposition)); } - uiout->field_signed ("bkptno", b->number); - if (c->is_vfork) + uiout->field_signed ("bkptno", number); + if (is_vfork) uiout->text (" (vforked process "); else uiout->text (" (forked process "); - uiout->field_signed ("newpid", c->forked_inferior_pid.pid ()); + uiout->field_signed ("newpid", forked_inferior_pid.pid ()); uiout->text ("), "); return PRINT_SRC_AND_LOC; } -/* Implement the "print_one" breakpoint_ops method for fork - catchpoints. */ +/* Implement the "print_one" method for fork catchpoints. */ -static bool -print_one_catch_fork (struct breakpoint *b, struct bp_location **last_loc) +bool +fork_catchpoint::print_one (struct bp_location **last_loc) { - struct fork_catchpoint *c = (struct fork_catchpoint *) b; struct value_print_options opts; struct ui_out *uiout = current_uiout; @@ -142,12 +142,12 @@ print_one_catch_fork (struct breakpoint *b, struct bp_location **last_loc) if (opts.addressprint) uiout->field_skip ("addr"); annotate_field (5); - const char *name = c->is_vfork ? "vfork" : "fork"; + const char *name = is_vfork ? "vfork" : "fork"; uiout->text (name); - if (c->forked_inferior_pid != null_ptid) + if (forked_inferior_pid != null_ptid) { uiout->text (", process "); - uiout->field_signed ("what", c->forked_inferior_pid.pid ()); + uiout->field_signed ("what", forked_inferior_pid.pid ()); uiout->spaces (1); } @@ -157,33 +157,24 @@ print_one_catch_fork (struct breakpoint *b, struct bp_location **last_loc) return true; } -/* Implement the "print_mention" breakpoint_ops method for fork - catchpoints. */ +/* Implement the "print_mention" method for fork catchpoints. */ -static void -print_mention_catch_fork (struct breakpoint *b) +void +fork_catchpoint::print_mention () { - struct fork_catchpoint *c = (struct fork_catchpoint *) b; - printf_filtered (_("Catchpoint %d (%s)"), c->number, - c->is_vfork ? "vfork" : "fork"); + printf_filtered (_("Catchpoint %d (%s)"), number, + is_vfork ? "vfork" : "fork"); } -/* Implement the "print_recreate" breakpoint_ops method for fork - catchpoints. */ +/* Implement the "print_recreate" method for fork catchpoints. */ -static void -print_recreate_catch_fork (struct breakpoint *b, struct ui_file *fp) +void +fork_catchpoint::print_recreate (struct ui_file *fp) { - struct fork_catchpoint *c = (struct fork_catchpoint *) b; - fprintf_unfiltered (fp, "catch %s", - c->is_vfork ? "vfork" : "fork"); - print_recreate_thread (b, fp); + fprintf_unfiltered (fp, "catch %s", is_vfork ? "vfork" : "fork"); + print_recreate_thread (this, fp); } -/* The breakpoint_ops structure to be used in fork catchpoints. */ - -static struct breakpoint_ops catch_fork_breakpoint_ops; - static void create_fork_vfork_event_catchpoint (struct gdbarch *gdbarch, bool temp, const char *cond_string, @@ -192,7 +183,7 @@ create_fork_vfork_event_catchpoint (struct gdbarch *gdbarch, std::unique_ptr c (new fork_catchpoint ()); init_catchpoint (c.get (), gdbarch, temp, cond_string, - &catch_fork_breakpoint_ops); + &vtable_breakpoint_ops); c->is_vfork = is_vfork; c->forked_inferior_pid = null_ptid; @@ -250,31 +241,10 @@ catch_fork_command_1 (const char *arg, int from_tty, } } -static void -initialize_ops () -{ - struct breakpoint_ops *ops; - - initialize_breakpoint_ops (); - - /* Fork catchpoints. */ - ops = &catch_fork_breakpoint_ops; - *ops = base_breakpoint_ops; - ops->insert_location = insert_catch_fork; - ops->remove_location = remove_catch_fork; - ops->breakpoint_hit = breakpoint_hit_catch_fork; - ops->print_it = print_it_catch_fork; - ops->print_one = print_one_catch_fork; - ops->print_mention = print_mention_catch_fork; - ops->print_recreate = print_recreate_catch_fork; -} - void _initialize_break_catch_fork (); void _initialize_break_catch_fork () { - initialize_ops (); - add_catch_command ("fork", _("Catch calls to fork."), catch_fork_command_1, NULL, -- 2.31.1