From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id A45F13858034 for ; Tue, 18 Jan 2022 19:40:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A45F13858034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 14A3C1003BE0A for ; Tue, 18 Jan 2022 19:40:12 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 9uKxnWP9FEaNC9uKxnPhiN; Tue, 18 Jan 2022 19:40:12 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=dJtjJMVb c=1 sm=1 tr=0 ts=61e7179c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=0nDpaMCJZoQfEXHsO34A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=L9EmB/QCM1jTbVL16oEcdayZcqCmY9ucfll3hXc2g0g=; b=TNr4xB4MILqwN3L8ymOD51Ozm2 aXI5GWnRAJ3b335/l3GMr1CvgMmG7kGKbLLtH+12nRa9IKZPDzV4Fp7LbfxIOjvNkcZuAlJ3ZkHVR kEMk39ck0yVTqBM/DuFIIoIrF; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:40582 helo=prentzel.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9uKx-0015NP-4v; Tue, 18 Jan 2022 12:40:11 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 04/36] Delete some unnecessary wrapper functions Date: Tue, 18 Jan 2022 12:39:35 -0700 Message-Id: <20220118194007.2853108-5-tom@tromey.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220118194007.2853108-1-tom@tromey.com> References: <20220118194007.2853108-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n9uKx-0015NP-4v X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (prentzel.Home) [75.166.134.30]:40582 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3031.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 19:40:14 -0000 This patch deletes a few unnecessary wrapper functions from breakpoint.c. --- gdb/breakpoint.c | 68 +++--------------------------------------------- 1 file changed, 4 insertions(+), 64 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index a0b8bd4e127..06c52bb5b3a 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -11828,36 +11828,6 @@ bkpt_print_recreate (struct breakpoint *tp, struct ui_file *fp) print_recreate_thread (tp, fp); } -static void -bkpt_create_sals_from_location (struct event_location *location, - struct linespec_result *canonical, - enum bptype type_wanted) -{ - create_sals_from_location_default (location, canonical, type_wanted); -} - -static void -bkpt_create_breakpoints_sal (struct gdbarch *gdbarch, - struct linespec_result *canonical, - gdb::unique_xmalloc_ptr cond_string, - gdb::unique_xmalloc_ptr extra_string, - enum bptype type_wanted, - enum bpdisp disposition, - int thread, - int task, int ignore_count, - const struct breakpoint_ops *ops, - int from_tty, int enabled, - int internal, unsigned flags) -{ - create_breakpoints_sal_default (gdbarch, canonical, - std::move (cond_string), - std::move (extra_string), - type_wanted, - disposition, thread, task, - ignore_count, ops, from_tty, - enabled, internal, flags); -} - static std::vector bkpt_decode_location (struct breakpoint *b, struct event_location *location, @@ -12140,36 +12110,6 @@ tracepoint_print_recreate (struct breakpoint *self, struct ui_file *fp) fprintf_unfiltered (fp, " passcount %d\n", tp->pass_count); } -static void -tracepoint_create_sals_from_location (struct event_location *location, - struct linespec_result *canonical, - enum bptype type_wanted) -{ - create_sals_from_location_default (location, canonical, type_wanted); -} - -static void -tracepoint_create_breakpoints_sal (struct gdbarch *gdbarch, - struct linespec_result *canonical, - gdb::unique_xmalloc_ptr cond_string, - gdb::unique_xmalloc_ptr extra_string, - enum bptype type_wanted, - enum bpdisp disposition, - int thread, - int task, int ignore_count, - const struct breakpoint_ops *ops, - int from_tty, int enabled, - int internal, unsigned flags) -{ - create_breakpoints_sal_default (gdbarch, canonical, - std::move (cond_string), - std::move (extra_string), - type_wanted, - disposition, thread, task, - ignore_count, ops, from_tty, - enabled, internal, flags); -} - static std::vector tracepoint_decode_location (struct breakpoint *b, struct event_location *location, @@ -14487,8 +14427,8 @@ initialize_breakpoint_ops (void) ops->insert_location = bkpt_insert_location; ops->remove_location = bkpt_remove_location; ops->breakpoint_hit = bkpt_breakpoint_hit; - ops->create_sals_from_location = bkpt_create_sals_from_location; - ops->create_breakpoints_sal = bkpt_create_breakpoints_sal; + ops->create_sals_from_location = create_sals_from_location_default; + ops->create_breakpoints_sal = create_breakpoints_sal_default; ops->decode_location = bkpt_decode_location; /* The breakpoint_ops structure to be used in regular breakpoints. */ @@ -14570,8 +14510,8 @@ initialize_breakpoint_ops (void) ops->print_one_detail = tracepoint_print_one_detail; ops->print_mention = tracepoint_print_mention; ops->print_recreate = tracepoint_print_recreate; - ops->create_sals_from_location = tracepoint_create_sals_from_location; - ops->create_breakpoints_sal = tracepoint_create_breakpoints_sal; + ops->create_sals_from_location = create_sals_from_location_default; + ops->create_breakpoints_sal = create_breakpoints_sal_default; ops->decode_location = tracepoint_decode_location; /* Probe tracepoints. */ -- 2.31.1