From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 63900385842B for ; Sat, 22 Jan 2022 01:38:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63900385842B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id CBBE41003FA23 for ; Sat, 22 Jan 2022 01:38:12 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id B5M4nIXZQ2s5dB5M4nxF2a; Sat, 22 Jan 2022 01:38:12 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BOh2EHcG c=1 sm=1 tr=0 ts=61eb6004 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=SKHJKMchyA5OOJ9IWwsA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/4sQeScfpT4KhiHtBTlFDN/YTIvGIj0EdX9TYtghQUE=; b=kkA7Yx9q3iSRFCh7pvbgQGzuEq G0ERXmHK7aNLXHBBAwqcePA97jxIQIPIcjobhIbAFDCNdyMYM4pROgQcQuGyFRXUjcQxSjnftNRxm fQSpXxw/kCD6rtprA5+x/f9RO; Received: from 75-166-128-165.hlrn.qwest.net ([75.166.128.165]:40604 helo=prentzel.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nB5M4-001DkZ-0F; Fri, 21 Jan 2022 18:38:12 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 18/19] Minor comment updates in utils.h Date: Fri, 21 Jan 2022 18:38:00 -0700 Message-Id: <20220122013801.666659-19-tom@tromey.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220122013801.666659-1-tom@tromey.com> References: <20220122013801.666659-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.128.165 X-Source-L: No X-Exim-ID: 1nB5M4-001DkZ-0F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-128-165.hlrn.qwest.net (prentzel.Home) [75.166.128.165]:40604 X-Source-Auth: tom+tromey.com X-Email-Count: 19 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jan 2022 01:38:15 -0000 This patch updates some comments in utils.h to more closely reflect the new reality. --- gdb/utils.h | 32 ++++++++++++-------------------- 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/gdb/utils.h b/gdb/utils.h index 011597b4925..b9baaadbb6f 100644 --- a/gdb/utils.h +++ b/gdb/utils.h @@ -190,11 +190,8 @@ extern struct ui_file **current_ui_gdb_stdin_ptr (void); extern struct ui_file **current_ui_gdb_stderr_ptr (void); extern struct ui_file **current_ui_gdb_stdlog_ptr (void); -/* Flush STREAM. This is a wrapper for ui_file_flush that also - flushes any output pending from uses of the *_filtered output - functions; that output is kept in a special buffer so that - pagination and styling are handled properly. */ -extern void gdb_flush (struct ui_file *); +/* Flush STREAM. */ +extern void gdb_flush (struct ui_file *stream); /* The current top level's ui_file streams. */ @@ -202,20 +199,16 @@ extern void gdb_flush (struct ui_file *); #define gdb_stdout (*current_ui_gdb_stdout_ptr ()) /* Input stream */ #define gdb_stdin (*current_ui_gdb_stdin_ptr ()) -/* Serious error notifications */ +/* Serious error notifications. This bypasses the pager, if one is in + use. */ #define gdb_stderr (*current_ui_gdb_stderr_ptr ()) -/* Log/debug/trace messages that should bypass normal stdout/stderr - filtering. For moment, always call this stream using - *_unfiltered. In the very near future that restriction shall be - removed - either call shall be unfiltered. (cagney 1999-06-13). */ +/* Log/debug/trace messages that bypasses the pager, if one is in + use. */ #define gdb_stdlog (*current_ui_gdb_stdlog_ptr ()) /* Truly global ui_file streams. These are all defined in main.c. */ -/* Target output that should bypass normal stdout/stderr filtering. - For moment, always call this stream using *_unfiltered. In the - very near future that restriction shall be removed - either call - shall be unfiltered. (cagney 1999-07-02). */ +/* Target output that should bypass the pager, if one is in use. */ extern struct ui_file *gdb_stdtarg; extern struct ui_file *gdb_stdtargerr; extern struct ui_file *gdb_stdtargin; @@ -224,12 +217,6 @@ extern struct ui_file *gdb_stdtargin; extern void set_screen_width_and_height (int width, int height); -/* More generic printf like operations. Filtered versions may return - non-locally on error. As an extension over plain printf, these - support some GDB-specific format specifiers. Particularly useful - here are the styling formatters: '%p[', '%p]' and '%ps'. See - ui_out::message for details. */ - extern void gdb_puts (const char *, struct ui_file *); extern int gdb_putc (int c, struct ui_file *); @@ -245,6 +232,11 @@ extern void gdb_vprintf (const char *, va_list) ATTRIBUTE_PRINTF (1, 0); extern void gdb_vprintf (struct ui_file *, const char *, va_list) ATTRIBUTE_PRINTF (2, 0); +/* More generic printf like operations. As an extension over plain + printf, these support some GDB-specific format specifiers. + Particularly useful here are the styling formatters: '%p[', '%p]' + and '%ps'. See ui_out::message for details. */ + extern void gdb_printf (struct ui_file *, const char *, ...) ATTRIBUTE_PRINTF (2, 3); -- 2.31.1