From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D0E383858421 for ; Wed, 26 Jan 2022 19:51:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D0E383858421 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-149-yB_AS4jFNwyZukV6WT-J_g-1; Wed, 26 Jan 2022 14:51:22 -0500 X-MC-Unique: yB_AS4jFNwyZukV6WT-J_g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F1AD100CCC1 for ; Wed, 26 Jan 2022 19:51:21 +0000 (UTC) Received: from blarsen.com (ovpn-116-36.gru2.redhat.com [10.97.116.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E7164ABBC; Wed, 26 Jan 2022 19:51:19 +0000 (UTC) From: Bruno Larsen To: gdb-patches@sourceware.org Subject: [PATCH 03/11] Change gdb.base/skip-solib.exp deal with lack of epilogue information Date: Wed, 26 Jan 2022 16:50:45 -0300 Message-Id: <20220126195053.69559-4-blarsen@redhat.com> In-Reply-To: <20220126195053.69559-1-blarsen@redhat.com> References: <20220126195053.69559-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2022 19:51:25 -0000 When testing with clang, this feature worked, but the test failed because it checked specifically to see if we were at the main function. Without epilogue information, the inferior would be at libc_start_main (or equivalent) instead. Having this test changed would allows us to identify if the test stops working for real at some point. --- gdb/testsuite/gdb.base/skip-solib.exp | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.base/skip-solib.exp b/gdb/testsuite/gdb.base/skip-solib.exp index ce2b080229e..99833533b6a 100644 --- a/gdb/testsuite/gdb.base/skip-solib.exp +++ b/gdb/testsuite/gdb.base/skip-solib.exp @@ -82,7 +82,7 @@ with_test_prefix "ignoring solib file" { # We shouldn't step into square(), since we skipped skip-solib-lib.c. # gdb_test "step" "" - gdb_test "bt" "#0\\s+main.*" + gdb_test "bt 1" "#0.*main.*" } # @@ -114,5 +114,12 @@ with_test_prefix "ignoring solib function" { # the last line of square. # gdb_test "step" "" - gdb_test "bt" "#0\\s+square.*" + gdb_test_multiple "bt 1" "skipped multiply" { + -re "#0\\s+square.*" { + pass "skipped multiply" + } + -re "#0.*main.*" { + pass "skipped multiply" + } + } } -- 2.31.1