From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2089.outbound.protection.outlook.com [40.107.220.89]) by sourceware.org (Postfix) with ESMTPS id E83E33858C2C for ; Wed, 2 Feb 2022 18:44:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E83E33858C2C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UV4Ki0cuicFi+aLjSOEm4By3/kSMQLKFQJtvia5IffopTSMNnD08Koirrjhuo+Di68Ei8WrBLmP5ZSml6VcrptKZp8jLms0M5pBLJuVViisjTcdz/gxmkDljk9f4CVoFwFndZFAdVSvb1ynZxjFl/80n4rMo+uYpDMUwGslinqq1TBjbCREZsFIuBmvT5TT0cEQzMMjMd8qdP05iMNSb/bU00PFTbBNnF5l1r2JPL50ICdKgSxwOzrRoRSMlFPga2guu60ujhAEAFwMvBM6vY/8qLhUlNxnKnUFi+tNHzFIFFqTzrOJEzXHEftp8V2LOt0iYJ2HVNXNXbg8PYESaAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6CPkMlx6agwSlk23IXVCQmjHPNpC3yHNPbynKpYN2yQ=; b=bwurxY1El7upgCnvqAFHXdzGWvRepLOUXEOPmKMeyQh+Nwo2w61aSDLQ7sHBeesBU2w5MAbQS5ROKRP0ElSyXa8/RDfNQxrCcTq+urZhlNUYWWr012u0dj0v4yYuOxFbYy28Jp6xTNyVUGLCatcosi7nwEmcJOoKgY1n1tYrzIH4Zonj+yn3emyNbYmD11UsMBPXc5q4yeazDBxMIKQ+j941KVcX8I9KeMt51N1bHyLoSMLxt6Fiaoynzd2ZZlyGIOcuonKfGIoklV5IUS98x3zF7JL/lVfgC3tAlpX7ics+u+kVjU9eH97a9MwPbZ3CwQ80/GeYfLEMBdAQ7YhaxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from MW4PR02CA0004.namprd02.prod.outlook.com (2603:10b6:303:16d::19) by CH2PR12MB4858.namprd12.prod.outlook.com (2603:10b6:610:67::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb 2022 18:44:30 +0000 Received: from CO1NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:303:16d:cafe::7c) by MW4PR02CA0004.outlook.office365.com (2603:10b6:303:16d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 18:44:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT034.mail.protection.outlook.com (10.13.174.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 18:44:30 +0000 Received: from node-bp126-r03c.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 2 Feb 2022 12:44:27 -0600 From: Lancelot SIX To: CC: , Lancelot SIX Subject: [PATCH v3 0/2] Make GDB respect the DW_CC_nocall attribute Date: Wed, 2 Feb 2022 12:41:13 -0600 Message-ID: <20220202184115.83396-1-lancelot.six@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea64f240-1783-4c78-a592-08d9e67c0c42 X-MS-TrafficTypeDiagnostic: CH2PR12MB4858:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2201; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: om6bFMeqKwWFLIzWy+vp1BB16qcj5+fFjLbGUBsQmjTUcUG1Y7nz1hK1v3uwmb+p5ZKeGY7h44gS63jYzc6aQwL8GUqISBk5viWA5QFuKSjaWSImOpt6Q9BrJaJWU78Z6x2taPSg7BMhv1GvLaoxgu58CSJ6iZNO0OLkSyaffdtc9nLTuOfvNzoVXBEn5tUpCXsFU+jNRKtl0WPnKosZbz9HjKVxCoH6LwQQ1VChiv5CnDjM7WaBXO7GgphtirY54n56aQW0evZU+QOs8Dcwmjv83+suA7G0zj2lpYPxE1so0bWQ9VP2DzuQaqAqrKZuAgc/qWVGYunSHdquORCBWaD2amAhChs0sfmAIPr71vBR94VH/xY5vgL7P5l74wJFQu+kZYd3akiH7wOruYClC+5QzWB6ZswJfPyrck6UMwNNTSysYHMFkH0tipn2HBApMEwnmaC9PWH/ph4i3r9qvmNyRnk3yadjF/rWO9dARxfC8WANWTvtMs+Gs7DN/fG5Li3yLci7HcvM1QIxpKRNyoLbAYVeyqbX2PYJGEcGb2HB9zXiDzdBnsdqbS+NqMSv5Zhz996EyJ4OWV9ljBBci3aBdBuUGwtZv5UUtF7ZWc3TFc63/oc4WUBF54qn2Pc9QSd/QExAbMmET0Ljhba44MuOGc5tXE/ifeFS/Dz5oyo3ruiTcXkMgivUW5N/ocnLuDhfS3weUIoi2InGY0Qz4hovqH6mHpnxJHIFZ7Rwap7i1yVXAa7Nnc0C7VTIh0Ys28xig8TKxZGVIGfPkiT8wXOthaDirfsNjzmO5hw02GE= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(186003)(81166007)(356005)(1076003)(26005)(426003)(966005)(82310400004)(2616005)(336012)(508600001)(2906002)(16526019)(40460700003)(36860700001)(316002)(83380400001)(36756003)(47076005)(5660300002)(54906003)(6916009)(8936002)(70206006)(86362001)(4326008)(7696005)(8676002)(70586007)(6666004)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 18:44:30.3632 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea64f240-1783-4c78-a592-08d9e67c0c42 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4858 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Feb 2022 18:44:35 -0000 Hi, This is a V3 following https://sourceware.org/pipermail/gdb-patches/2022-January/185563.html. Noticeable changes since V2: - Instead of using get_function_name (COREADDR, ...) in order to format messages displayed to the user in get_return_value, this series now ensures that the function's symbol is passed to get_return_value. With the symbol available, getting the function name is a matter of calling 'symbol::print_name'. This overall simplifies the implementation. To simplify the review process, changes required to have the symbol in get_return_value are done in a preparatory patch. - Fix coding style issues reported by Bruno. - Remove newline at the end of the testcase. Thanks to Bruno and Simon for the comments. Tested on x86_64-linux with no regression observed. All feedback welcome. Best, Lancelot. Lancelot SIX (2): gdb: add a symbol* argument to get_return_value gdb: Respect the DW_CC_nocall attribute gdb/gdbtypes.c | 11 +++ gdb/gdbtypes.h | 10 ++ gdb/infcall.c | 5 + gdb/infcmd.c | 14 ++- gdb/inferior.h | 3 +- gdb/python/py-finishbreakpoint.c | 29 ++++-- gdb/stack.c | 18 +++- gdb/testsuite/gdb.dwarf2/calling-convention.c | 35 +++++++ .../gdb.dwarf2/calling-convention.exp | 97 +++++++++++++++++++ 9 files changed, 207 insertions(+), 15 deletions(-) create mode 100644 gdb/testsuite/gdb.dwarf2/calling-convention.c create mode 100644 gdb/testsuite/gdb.dwarf2/calling-convention.exp base-commit: 0d8cbc5f2fcbcb9eb207f12507fdfe04f3d3ae14 -- 2.25.1