From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lsix@lancelotsix.com>
Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111])
 by sourceware.org (Postfix) with ESMTPS id A6C583858D35
 for <gdb-patches@sourceware.org>; Thu,  3 Feb 2022 15:46:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6C583858D35
Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:8c4a:4874:fbf9:5145])
 by lndn.lancelotsix.com (Postfix) with ESMTPSA id 90DD081859;
 Thu,  3 Feb 2022 15:46:28 +0000 (UTC)
Date: Thu, 3 Feb 2022 15:46:24 +0000
From: Lancelot SIX <lsix@lancelotsix.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Lancelot SIX <lancelot.six@amd.com>, simark@simark.ca,
 gdb-patches@sourceware.org
Subject: Re: [PATCH v4] gdb: add a symbol* argument to get_return_value
Message-ID: <20220203154624.m63nmq3wbenwfis2@Plymouth>
References: <8ebbde37-0acc-c430-ea36-d21c14163ef8@simark.ca>
 <20220202215914.23534-1-lancelot.six@amd.com>
 <cef7b867-4474-3499-3684-4de4a07dd7bd@polymtl.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cef7b867-4474-3499-3684-4de4a07dd7bd@polymtl.ca>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11
 (lndn.lancelotsix.com [0.0.0.0]); Thu, 03 Feb 2022 15:46:28 +0000 (UTC)
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2022 15:46:31 -0000

> -		  struct value *func_value;
> -
>  		  /* Ignore Python errors at this stage.  */
> -		  self_bpfinish->return_type = type_to_type_object (ret_type);
> -		  PyErr_Clear ();
> -		  func_value = read_var_value (function, NULL, frame);
> -		  self_bpfinish->function_value =
> -		      value_to_value_object (func_value);
> +		  value *func_value = read_var_value (function, NULL, frame);
> +		  self_bpfinish->function_value
> +		    = value_to_value_object (func_value);
>  		  PyErr_Clear ();
> +
> +		  self_bpfinish->func_symbol
> +		    = symbol_to_symbol_object (function);

Shouldn’t there be a call to PyErr_Clear () here? (I did forget it initially).

Lancelot