From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id B10CE3858D3C for ; Wed, 16 Feb 2022 06:24:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B10CE3858D3C From: Hans-Peter Nilsson To: Mike Frysinger CC: In-Reply-To: (message from Mike Frysinger on Tue, 15 Feb 2022 23:49:47 -0500) Subject: Re: [PATCH 06/12] sim/testsuite: Support "requires: simoption <--name-of-option>" MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20220214225824.AC90A20439@pchp3.se.axis.com> <20220214230356.BA97820439@pchp3.se.axis.com> Message-ID: <20220216062451.703AD2040B@pchp3.se.axis.com> Date: Wed, 16 Feb 2022 07:24:51 +0100 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 06:24:54 -0000 > Date: Tue, 15 Feb 2022 23:49:47 -0500 > From: Mike Frysinger > On 15 Feb 2022 00:03, Hans-Peter Nilsson via Gdb-patches wrote: > > Simulator features can be present or not, typically > > depending on different-valued configure options, like > > --enable-sim-hardware[=off|=on]. To avoid failures in > > test-suite-runs when testing such configurations, a new > > predicate is needed, as neither "target", "progos" nor > > "mach" fits cleanly. > > > > The immediate need was to check for presence of a simulator > > option, but rather than a specialized "requires-simoption:" > > predicate I thought I'd handle the general (parametrized) > > need, so here's a generic predicate machinery and a (first) > > predicate to use together with it; checking whether a > > particular option is supported, by looking at "run --help" > > output. This was inspired by the check_effective_target_ > > machinery in the gcc test-suite. > > i really don't want --help to be an API surface like this. it's the wrong > layer for the job. > > we have a sim_config_print function which dumps configuration information. > i'd be fine making that the surface to build off of. i don't think we > print hardware there atm, but should be trivial to introduce. > > only other missing piece is that it's not obvious how to access it from > the CLI. `run --version` doesn't include it. `run --do-command version` > does though :x. i'd be amenable to improving this interface, either by a > new option like --info-config or some other route. But, "run --version" is a check for the *option* to exist, which exactly meets the need. You describe a probe for a particular *configuration*, which is arguably useful, but not for checking whether a particular option is supported. brgds, H-P