From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id B5CA93858D3C for ; Wed, 16 Feb 2022 06:41:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5CA93858D3C From: Hans-Peter Nilsson To: Mike Frysinger CC: In-Reply-To: (message from Mike Frysinger on Wed, 16 Feb 2022 00:02:23 -0500) Subject: Re: [PATCH 10/12] sim: Add sim_dump_memory for debugging MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20220214225824.AC90A20439@pchp3.se.axis.com> <20220214230631.BA3A320439@pchp3.se.axis.com> Message-ID: <20220216064157.9F54F20417@pchp3.se.axis.com> Date: Wed, 16 Feb 2022 07:41:57 +0100 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 06:42:00 -0000 > Date: Wed, 16 Feb 2022 00:02:23 -0500 > From: Mike Frysinger > On 15 Feb 2022 00:06, Hans-Peter Nilsson via Gdb-patches wrote: > > --- a/sim/common/sim-memopt.c > > +++ b/sim/common/sim-memopt.c > > > > +/* Convenience function for use when debugging the simulator. */ > > can you clarify that it's meant for an attached debugger to call vs a > manual call from within the sim itself ? i know your commit message > said that, but the code comment would help too. Committed. ---- 8< ---- sim/common: Improve sim_dump_memory head comment As requested by Mike. * sim-memopt.c: Improve head comment. --- sim/common/sim-memopt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sim/common/sim-memopt.c b/sim/common/sim-memopt.c index 62423421cf9c..1f7186c5e12d 100644 --- a/sim/common/sim-memopt.c +++ b/sim/common/sim-memopt.c @@ -641,7 +641,8 @@ sim_memory_uninstall (SIM_DESC sd) void sim_dump_memory (SIM_DESC sd); -/* Convenience function for use when debugging the simulator. */ +/* Convenience function for use when debugging the simulator, to be + called from within e.g. gdb. */ void sim_dump_memory (SIM_DESC sd) -- 2.30.2