From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id 2B2393858D3C for ; Wed, 16 Feb 2022 06:44:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2B2393858D3C From: Hans-Peter Nilsson To: Mike Frysinger CC: In-Reply-To: (message from Mike Frysinger on Tue, 15 Feb 2022 23:57:00 -0500) Subject: Re: [PATCH 11/12] sim/testsuite/cris: Remove faulty use of basename in C tests MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20220214225824.AC90A20439@pchp3.se.axis.com> <20220214230724.2C0AA20439@pchp3.se.axis.com> Message-ID: <20220216064400.0628320417@pchp3.se.axis.com> Date: Wed, 16 Feb 2022 07:44:00 +0100 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 06:44:02 -0000 > Date: Tue, 15 Feb 2022 23:57:00 -0500 > From: Mike Frysinger > On 15 Feb 2022 00:07, Hans-Peter Nilsson via Gdb-patches wrote: > > --- a/sim/testsuite/cris/c/stat3.c > > +++ b/sim/testsuite/cris/c/stat3.c > > @@ -7,13 +7,14 @@ > > #include > > #include > > #include > > +#define mybasename(x) ({ const char *x_ = (x), *y_ = strrchr (x_, '/'); y_ != NULL ? y_ + 1 : x_; }) > > > > int main (int argc, char *argv[]) > > { > > char path[1024] = "/"; > > struct stat buf; > > > > - strcat (path, basename (argv[0])); > > + strcat (path, mybasename(argv[0])); > > GNU style (and this file style) says to put space before the ( > -mike Now that's a nit if ever I saw one; it's in the test-suite! Committed. --- 8< --- sim/testsuite/cris/c/stat3.c: Fix formatting nit * c/stat3.c (main): Fix formatting nit. --- sim/testsuite/cris/c/stat3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/testsuite/cris/c/stat3.c b/sim/testsuite/cris/c/stat3.c index f7c96045832c..321da1b2bd61 100644 --- a/sim/testsuite/cris/c/stat3.c +++ b/sim/testsuite/cris/c/stat3.c @@ -14,7 +14,7 @@ int main (int argc, char *argv[]) char path[1024] = "/"; struct stat buf; - strcat (path, mybasename(argv[0])); + strcat (path, mybasename (argv[0])); if (stat (".", &buf) != 0 || !S_ISDIR (buf.st_mode)) abort (); -- 2.30.2