From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id CF0C13858423 for ; Wed, 16 Feb 2022 13:55:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CF0C13858423 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 2B15A100477F4 for ; Wed, 16 Feb 2022 13:55:27 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id KKmEnON682s5dKKmEn4nSF; Wed, 16 Feb 2022 13:55:27 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BOh2EHcG c=1 sm=1 tr=0 ts=620d024f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oGFeUVbbRNcA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=Sn3-RZVu0iRpGP54ztcA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lHeU8Eq74B679kMTmbpIL99VkPx9SdaCia2EhEJ2WcQ=; b=WV4slvA0mNc9d7cmnR75DdAZVb JSlGGfG2+kh4tbtNDWrbUanrpU0B+1+GcE+5jrQbGbVXgMahY2vJEsvs0hhtij8exOh7gLfqVHHvK HyVrUbjcskfny4b8K+j5CBVP9; Received: from 97-122-95-113.hlrn.qwest.net ([97.122.95.113]:41018 helo=prentzel.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nKKmE-000GMY-5W; Wed, 16 Feb 2022 06:55:26 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 01/18] Fix latent quote char bug in generic_printstr Date: Wed, 16 Feb 2022 06:55:01 -0700 Message-Id: <20220216135518.3162480-2-tom@tromey.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220216135518.3162480-1-tom@tromey.com> References: <20220216135518.3162480-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.95.113 X-Source-L: No X-Exim-ID: 1nKKmE-000GMY-5W X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-95-113.hlrn.qwest.net (prentzel.Home) [97.122.95.113]:41018 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3031.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 13:55:29 -0000 generic_printstr prints an empty string like: fputs_filtered ("\"\"", stream); However, this seems wrong to me if the quote character is something other than double quote. This patch fixes this latent bug, though I'm not sure how to test it -- I don't know Fortran and in my experiment I was unable to make a zero-length Fortran string. --- gdb/valprint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/valprint.c b/gdb/valprint.c index d6ec64845f4..e4d68381189 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -2632,7 +2632,7 @@ generic_printstr (struct ui_file *stream, struct type *type, if (length == 0) { - fputs_filtered ("\"\"", stream); + fprintf_filtered (stream, "%c%c", quote_char, quote_char); return; } -- 2.31.1