From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 758303858C20 for ; Wed, 16 Feb 2022 15:52:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 758303858C20 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-246-sjVKjFozO86OeDazbehsNA-1; Wed, 16 Feb 2022 10:52:37 -0500 X-MC-Unique: sjVKjFozO86OeDazbehsNA-1 Received: by mail-wm1-f71.google.com with SMTP id r8-20020a7bc088000000b0037bbf779d26so615104wmh.7 for ; Wed, 16 Feb 2022 07:52:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1fEwyzfqWwK9zoS4/pyqyrAnWC78lV8Ip/ybTSHaR4Y=; b=VKUUTEm/OK930vtU5dmt2d58l9GpZ1oYYigtA+Esz3RlnPAJHoR1EeHDqkiKOuTDSC dvBnuTw3hJvP9alK1VwU61M0Uo1QBVdWIz2J2qlB3pKbSr13J4WYjmaBiSR7BOkdpVd3 p68p97pNoarrrCG8TIjRizOFOh7+xbDGCr/EWQbI4FxvPZgk8MASXuJYBQvOJrGTCzx4 YUxj6zvmHKoVmnrExZduXXjoUU2552IWAog16DY4kcA7Fr/kMLmkOk9m3INPBkEmMj8C 6vhPyiT8R9us4rVN/EVFfTAXFIBWwwvV/SZdH05pvxJnTT0lVc/w9T+7NL5BVPzYuRP1 C6wA== X-Gm-Message-State: AOAM532voeZlXl/7jVVbDkZbjNfs/f3UUjmvzTQGQwAD9d3lbQrLoVkZ l/ieObr02Vw/PKHUBolcXC+wl4XmXx29+RPVYnGHMztI+1XAsqQEZXnHZ8XrMqo3OGNOJnsFuJu T93YvFuycgABH663OWfnB9g== X-Received: by 2002:a5d:518c:0:b0:1e3:266c:99d9 with SMTP id k12-20020a5d518c000000b001e3266c99d9mr2800456wrv.377.1645026756545; Wed, 16 Feb 2022 07:52:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJydD6y9OwuL2ib09Q2I+OkSw50W+aKCfUzDk+25hpb9U8ds8CLaVck3EJVlofPpLzrkN3KTJw== X-Received: by 2002:a5d:518c:0:b0:1e3:266c:99d9 with SMTP id k12-20020a5d518c000000b001e3266c99d9mr2800448wrv.377.1645026756355; Wed, 16 Feb 2022 07:52:36 -0800 (PST) Received: from localhost (host86-134-151-224.range86-134.btcentralplus.com. [86.134.151.224]) by smtp.gmail.com with ESMTPSA id p16sm12507445wmq.18.2022.02.16.07.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 07:52:35 -0800 (PST) Date: Wed, 16 Feb 2022 15:52:35 +0000 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 05/18] Don't use wchar_printable in print_wchar Message-ID: <20220216155235.GI2571@redhat.com> References: <20220216135518.3162480-1-tom@tromey.com> <20220216135518.3162480-6-tom@tromey.com> MIME-Version: 1.0 In-Reply-To: <20220216135518.3162480-6-tom@tromey.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 15:52:19 up 5 days, 5:31, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 15:52:40 -0000 * Tom Tromey [2022-02-16 06:55:05 -0700]: > print_wchar uses wchar_printable, but this isn't needed -- all the > relevant cases are already handled by the 'switch'. This changes the > code to use gdb_iswprint, and removes a somewhat confusing comment > related to this code. LGTM. Thanks, Andrew > --- > gdb/valprint.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/gdb/valprint.c b/gdb/valprint.c > index e758c1d1066..17ad46c87b5 100644 > --- a/gdb/valprint.c > +++ b/gdb/valprint.c > @@ -2197,9 +2197,6 @@ print_wchar (gdb_wint_t w, const gdb_byte *orig, > > *need_escapep = false; > > - /* iswprint implementation on Windows returns 1 for tab character. > - In order to avoid different printout on this host, we explicitly > - use wchar_printable function. */ > switch (w) > { > case LCST ('\a'): > @@ -2225,9 +2222,9 @@ print_wchar (gdb_wint_t w, const gdb_byte *orig, > break; > default: > { > - if (wchar_printable (w) && (!need_escape || (!gdb_iswdigit (w) > - && w != LCST ('8') > - && w != LCST ('9')))) > + if (gdb_iswprint (w) && (!need_escape || (!gdb_iswdigit (w) > + && w != LCST ('8') > + && w != LCST ('9')))) > { > gdb_wchar_t wchar = w; > > -- > 2.31.1 >