From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy1-pub.mail.unifiedlayer.com (qproxy1-pub.mail.unifiedlayer.com [173.254.64.10]) by sourceware.org (Postfix) with ESMTPS id 18F09385AC3C for ; Thu, 17 Feb 2022 22:06:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18F09385AC3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from gproxy1-pub.mail.unifiedlayer.com (unknown [69.89.25.95]) by qproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 86EFB803149B for ; Thu, 17 Feb 2022 22:06:51 +0000 (UTC) Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 50CD21004733C for ; Thu, 17 Feb 2022 22:05:51 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id KouMn5bpHnAlUKouNnzJTg; Thu, 17 Feb 2022 22:05:51 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QIOt+iHL c=1 sm=1 tr=0 ts=620ec6bf a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oGFeUVbbRNcA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=VqoRAeVp4HIFgDOd3z8A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=I2oFB7LGopma8AD2xMH/47q4MN1IXPIh+o3vbIiqSS8=; b=JDz7q6BkJQtpl/iRc87iYpbgCL qK8I2nYTSEMFXSBr0sQe5oguB4e0BOcDeB2/wHSwBVTalZYNOWBFEueOeE0Q0dzTyQMrKNgPWS7ys SgNcz3bdZPeLZfZyyXWPLh+Ue; Received: from 75-166-146-214.hlrn.qwest.net ([75.166.146.214]:41036 helo=prentzel.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nKouM-002A2c-9j; Thu, 17 Feb 2022 15:05:50 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2 04/18] Remove c_printstr Date: Thu, 17 Feb 2022 15:05:32 -0700 Message-Id: <20220217220547.3874030-5-tom@tromey.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220217220547.3874030-1-tom@tromey.com> References: <20220217220547.3874030-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.146.214 X-Source-L: No X-Exim-ID: 1nKouM-002A2c-9j X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-146-214.hlrn.qwest.net (prentzel.Home) [75.166.146.214]:41036 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Feb 2022 22:06:53 -0000 This renames c_printstr, removing a layer of indirection. --- gdb/c-lang.c | 8 ++++---- gdb/c-lang.h | 8 -------- gdb/language.c | 12 ------------ gdb/rust-lang.c | 5 +++-- 4 files changed, 7 insertions(+), 26 deletions(-) diff --git a/gdb/c-lang.c b/gdb/c-lang.c index 342109c94ef..562736a5ee8 100644 --- a/gdb/c-lang.c +++ b/gdb/c-lang.c @@ -190,10 +190,10 @@ language_defn::printchar (int c, struct type *type, characters, or if FORCE_ELLIPSES. */ void -c_printstr (struct ui_file *stream, struct type *type, - const gdb_byte *string, unsigned int length, - const char *user_encoding, int force_ellipses, - const struct value_print_options *options) +language_defn::printstr (struct ui_file *stream, struct type *type, + const gdb_byte *string, unsigned int length, + const char *user_encoding, int force_ellipses, + const struct value_print_options *options) const { c_string_type str_type; const char *type_encoding; diff --git a/gdb/c-lang.h b/gdb/c-lang.h index 16c9b116393..5441bfe10c7 100644 --- a/gdb/c-lang.h +++ b/gdb/c-lang.h @@ -92,14 +92,6 @@ extern void c_value_print (struct value *, struct ui_file *, extern void c_printchar (int, struct type *, struct ui_file *); -extern void c_printstr (struct ui_file * stream, - struct type *elttype, - const gdb_byte *string, - unsigned int length, - const char *user_encoding, - int force_ellipses, - const struct value_print_options *options); - extern void c_language_arch_info (struct gdbarch *gdbarch, struct language_arch_info *lai); diff --git a/gdb/language.c b/gdb/language.c index 931abcd3076..20b6d8ccf9b 100644 --- a/gdb/language.c +++ b/gdb/language.c @@ -635,18 +635,6 @@ language_defn::value_print_inner /* See language.h. */ -void -language_defn::printstr (struct ui_file *stream, struct type *elttype, - const gdb_byte *string, unsigned int length, - const char *encoding, int force_ellipses, - const struct value_print_options *options) const -{ - c_printstr (stream, elttype, string, length, encoding, force_ellipses, - options); -} - -/* See language.h. */ - void language_defn::print_typedef (struct type *type, struct symbol *new_symbol, struct ui_file *stream) const diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c index 7584d2572fa..d2960d5dc62 100644 --- a/gdb/rust-lang.c +++ b/gdb/rust-lang.c @@ -283,8 +283,9 @@ rust_language::printstr (struct ui_file *stream, struct type *type, { /* This is probably some C string, so let's let C deal with it. */ - c_printstr (stream, type, string, length, user_encoding, - force_ellipses, options); + language_defn::printstr (stream, type, string, length, + user_encoding, force_ellipses, + options); return; } } -- 2.31.1