From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by sourceware.org (Postfix) with ESMTPS id E1EA13858D1E for ; Sat, 19 Feb 2022 21:24:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E1EA13858D1E Received: by mail-qv1-xf29.google.com with SMTP id e22so22062383qvf.9 for ; Sat, 19 Feb 2022 13:24:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jpuhcFK81dvIViWBTkbBh1GaN5IiFui4QEewALgynZU=; b=HF2/yZMgypDQ/814QqNSsfc3kmsm1MIvORhKWNRbVi95FqZ6TtyG6U0b2eKM+oRj8q M4JzzP2weSbJg1a4gmPFiRduUnoqCD/YerKMi7hPW9plKxPr2WtmqiJQ3CLl0MLcHS3Y Taazem6a664Ex6VJooTg3p8swmLDhA8OsId/+LXREwoMfkIgkuMD/Ql7pZxOD2ib0VQq ljhQpni5ljtD1iQ3jlvd0W/g4+6aJM+wxjxEvvmt6JIZDTfBn2vJstuvqB4sBTpqWLSN 3g4wuERQxLcQgm8ClmcuZpMmlwyCZzBp//RwIQ2+NgW2PqjaqzGM5kpxSTmfxxANEPYw hw8Q== X-Gm-Message-State: AOAM533ANfA3OcEhcHXnLDVnpUIXqJ9hPQVQujNS+TB+lQzqhhS8HkaB AwLI0xG/7nTBNhhMVI/wPj1iV4po42QRSQ== X-Google-Smtp-Source: ABdhPJyIcOl6QPAuNTLWkoDE3fK283dDEnD7WzOlm/tcDw97ItgLgasVcAeR4vUz/03uHDwMRj9YzQ== X-Received: by 2002:ad4:5749:0:b0:423:583e:2fa9 with SMTP id q9-20020ad45749000000b00423583e2fa9mr10366892qvx.61.1645305885306; Sat, 19 Feb 2022 13:24:45 -0800 (PST) Received: from localhost.localdomain (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id g8sm7605695qki.47.2022.02.19.13.24.43 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 19 Feb 2022 13:24:44 -0800 (PST) From: Philippe Blain To: gdb-patches@sourceware.org Cc: Tom de Vries , Doug Evans , Dominique Quatravaux , Sam Warner , Louis-He <1726110778@qq.com>, Simon Marchi Subject: [[RFC][PATCH][PR gdb/24069]] gdb/testsuite/README: update default value of INTERNAL_GDBFLAGS Date: Sat, 19 Feb 2022 16:24:42 -0500 Message-Id: <20220219212442.18136-1-levraiphilippeblain@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Feb 2022 21:24:47 -0000 The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013 ([gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS, 2020-10-26) to disable pagination, and in aae1c79a03a (PR python/12227..., 2010-12-07) to point to the data directory, but its default value mentioned in the testsuite's README was not kept up to date. Update the README accordingly, and mention where the default value is set, so that it's easier for futur new contributors to check if the default mentioned in the README is still current. --- Notes: I noticed that while testing the fix for PR 24069, since I wanted to use my '~/.gdbinit' with 'set startup-with-shell off' for all tests, and found out that setting INTERNAL_GDBFLAGS to only '-nw' made some things a little worse (as GDB was then missing '-data-directory'). gdb/testsuite/README | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/README b/gdb/testsuite/README index 7552774c78b..1ba50c43f73 100644 --- a/gdb/testsuite/README +++ b/gdb/testsuite/README @@ -168,11 +168,14 @@ INTERNAL_GDBFLAGS Command line options passed to all GDB invocations. -The default is "-nw -nx". +The default is set in lib/gdb.exp and is currently +"-nw -nx -data-directory /path/to/build/directory/gdb/data-directory -iex 'set height 0' -iex 'set width 0'". `-nw' disables any of the windowed interfaces. `-nx' disables ~/.gdbinit, so that it doesn't interfere with the tests. +`-data-directory` points the the data directory in the build directory +`-iex 'set {height,width} 0'` disable pagination This is actually considered an internal variable, and you won't normally want to change it. However, in some situations, @@ -193,7 +196,10 @@ a .gdbinit. For example: HOME=`pwd` runtest \ GDB=/usr/bin/gdb \ GDBSERVER=/usr/bin/gdbserver \ - INTERNAL_GDBFLAGS=-nw + INTERNAL_GDBFLAGS="-nw -iex 'set height 0' -iex 'set width 0'" + +Note that we do not need to specify '-data-directory' here +as we are testing an installed GDB. GDB_PARALLEL base-commit: 0acf434a23768449cbb4b3732355f3f2febecaee prerequisite-patch-id: aa40f05c60f391581f8aff17335000a5240d00cb prerequisite-patch-id: cfae52dea4b1af9a4c14ac4dbdcae3cda9c946db -- 2.29.2