From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by sourceware.org (Postfix) with ESMTPS id C5391385840F for ; Sat, 19 Feb 2022 23:40:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C5391385840F Received: by mail-qv1-xf2e.google.com with SMTP id f19so22523260qvb.6 for ; Sat, 19 Feb 2022 15:40:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3zO3LIY7Kgd53oQgYfCDnz/uMLVFq276AVxJaIY2NCM=; b=b2fTo7rphrXPthxdcFp8euze6aU8zXIpLSVFgV+ewOo1/GBi+FllsIdA4cTmF9bBcd HvvwrlrZ3sJ5Y0yaC38SyUexFtJNyyVfWGNsNuF11WMBZN68n6gNH8R7Z3MpuCiey7In YnVTwVAEo/QFjLPw/SgA1yAt/4KVcub4guLlGPf5nKWHACZ659W4nTW4cWs67049LCeK rm6dwaOW/9K+ooS8inTiQ8lAarT3juGXcKQnm6E6Ivb6EwWCXy6uKiab8sxu4m4y2tPx 0OmdhCRS63dEtfMmrIvoJ6Wtl2AZXkJCBws+3gagkv7vcWPKy7lDMPDL9UXtwYYm70No 5KIQ== X-Gm-Message-State: AOAM532Y1Pu/AqopN1FkQJuUk1zvpBCDNLZ27/2FoWVOtjOf/mOzj4vK PGQUiEy0hQItYXZXQ238/91FwZFGNKi4pw== X-Google-Smtp-Source: ABdhPJxyULhuF/2fCsDMlcKFKZr0J1egEzW13TJE6AhgTuTfYdAnB6Q02p+Yh/0K6/5qMhu2i+7EHg== X-Received: by 2002:a05:6214:400a:b0:431:7f6c:98fc with SMTP id kd10-20020a056214400a00b004317f6c98fcmr1788299qvb.122.1645314032045; Sat, 19 Feb 2022 15:40:32 -0800 (PST) Received: from localhost.localdomain (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id z23sm7677739qtn.40.2022.02.19.15.40.30 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 19 Feb 2022 15:40:31 -0800 (PST) From: Philippe Blain To: gdb-patches@sourceware.org Subject: [PATCH] gdb/testsuite/README: update default value of INTERNAL_GDBFLAGS Date: Sat, 19 Feb 2022 18:40:29 -0500 Message-Id: <20220219234029.28070-1-levraiphilippeblain@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Feb 2022 23:40:34 -0000 The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013 ([gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS, 2020-10-26) to disable pagination, and in aae1c79a03a (PR python/12227..., 2010-12-07) to point to the data directory, but its default value mentioned in the testsuite's README was not kept up to date. Update the README accordingly, and mention where the default value is set, so that it's easier for futur new contributors to check if the default mentioned in the README is still current. --- Notes: I noticed that while testing the fix for PR 24069, since I wanted to use my '~/.gdbinit' with 'set startup-with-shell off' for all tests, and found out that setting INTERNAL_GDBFLAGS to only '-nw' made some things a little worse (as GDB was then missing '-data-directory'). Meta note: when I sent this patch earlier (and messed-up my CCs) in [1], I was confused by the fact that my CCs for Simon, Doug Evans and Tom de Vries were not showing up on public-inbox, even in the "raw" view [2]. After a little web search I think this is due to them setting the mailman "avoid duplicates" setting [3]. [1] https://pi.simark.ca/gdb-patches/20220219212442.18136-1-levraiphilippeblain@gmail.com/T/#u [2] https://pi.simark.ca/gdb-patches/20220219212442.18136-1-levraiphilippeblain@gmail.com/raw [3] https://wiki.list.org/DOC/Mailman%202.1%20Members%20Manual#A7.2_How_can_I_avoid_getting_duplicate_messages.3F_.28duplicates_option.29 gdb/testsuite/README | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/README b/gdb/testsuite/README index 7552774c78b..2d3f1c45966 100644 --- a/gdb/testsuite/README +++ b/gdb/testsuite/README @@ -168,11 +168,14 @@ INTERNAL_GDBFLAGS Command line options passed to all GDB invocations. -The default is "-nw -nx". +The default is set in lib/gdb.exp and is currently +"-nw -nx -data-directory /path/to/build/directory/gdb/data-directory -iex 'set height 0' -iex 'set width 0'". `-nw' disables any of the windowed interfaces. `-nx' disables ~/.gdbinit, so that it doesn't interfere with the tests. +`-data-directory` points the the data directory in the build directory +`-iex 'set {height,width} 0'` disables pagination This is actually considered an internal variable, and you won't normally want to change it. However, in some situations, @@ -193,7 +196,10 @@ a .gdbinit. For example: HOME=`pwd` runtest \ GDB=/usr/bin/gdb \ GDBSERVER=/usr/bin/gdbserver \ - INTERNAL_GDBFLAGS=-nw + INTERNAL_GDBFLAGS="-nw -iex 'set height 0' -iex 'set width 0'" + +Note that we do not need to specify '-data-directory' here +as we are testing an installed GDB. GDB_PARALLEL base-commit: 0acf434a23768449cbb4b3732355f3f2febecaee -- 2.29.2