From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4FEF63858400 for ; Fri, 25 Feb 2022 17:54:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4FEF63858400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611-64xHUK3rP_qrvoYjd3FoDg-1; Fri, 25 Feb 2022 12:54:04 -0500 X-MC-Unique: 64xHUK3rP_qrvoYjd3FoDg-1 Received: by mail-wm1-f69.google.com with SMTP id 10-20020a1c020a000000b0037fae68fcc2so1887038wmc.8 for ; Fri, 25 Feb 2022 09:54:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=42q0s/2WgerS1dSlFXQIVTJLTDHtYxilps4lRkSaobE=; b=ftv+ZcFNfpR8hOkStbCy0DQ2/0cEIinUlmBPqplFcJDaI8S5YeTd3tRwzrCTUOLO8P /yZxhgfjL7nUkNdlBxnjrytFgqKfYvWvE1dc+gZbKaDRj2qBUsEpyLaJ3r24SE32z4vB 21g5gmHkZa5M3PHf0IHXLu5FxbwG9QrlxXrNtQqOecHuTHGoOBSL9kKrznUjeJzDiVGJ vgINi7aJLjb9KYULt7gejl9FkDVJiA9HeoTXvIG8YVKIfxApVFKERY0iRMNY6Yfz4UxM Bqufqxarx9zWhZxtH9Ldg5p4xJ5i2asyUWn3jQwYQTImYO1C3FL5iAlSrBe83H8rMA9P g5UA== X-Gm-Message-State: AOAM530l6biMaB+A9TVNErIGRGbdhTkf8XFUJLrrURfaHGeRtGGUWo3j dX+VCWbbwIRjU+8ZKiNvsvwcEV5UDd09nUQwJz/OB9XU9FC/hNa9psbS+BGfg6urtkUQ0lSbgQk jpLdM0bQLCSOk3VnRIMBT7vxZAdvQTSfO9dYk6CLbk2ibs6CdGGBkYOWnGtA1Cb+kvoLlTkZ9WQ == X-Received: by 2002:adf:ded1:0:b0:1ed:c056:4c5f with SMTP id i17-20020adfded1000000b001edc0564c5fmr6778114wrn.283.1645811642764; Fri, 25 Feb 2022 09:54:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJzG1svMXRnbtjzlwzHyNwxkwwgZJx3SGpTDo/GEdQygWHsbLa9fV2tbFlEBPGfTEPjxJ2ktgw== X-Received: by 2002:adf:ded1:0:b0:1ed:c056:4c5f with SMTP id i17-20020adfded1000000b001edc0564c5fmr6778095wrn.283.1645811642393; Fri, 25 Feb 2022 09:54:02 -0800 (PST) Received: from localhost (92.40.178.209.threembb.co.uk. [92.40.178.209]) by smtp.gmail.com with ESMTPSA id 8-20020a05600c26c800b0037bec3c03c9sm18203295wmv.2.2022.02.25.09.54.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 09:54:01 -0800 (PST) Date: Fri, 25 Feb 2022 17:54:00 +0000 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: add operator+= and operator+ overload for std::string Message-ID: <20220225175400.GB124242@redhat.com> References: <20220223103623.3161635-1-aburgess@redhat.com> <87bkyuopgc.fsf@tromey.com> MIME-Version: 1.0 In-Reply-To: <87bkyuopgc.fsf@tromey.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 17:53:26 up 14 days, 7:32, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2022 17:54:07 -0000 * Tom Tromey [2022-02-25 09:56:03 -0700]: > >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> This commit adds operator+= and operator+ overloads for adding > Andrew> gdb::unique_xmalloc_ptr to a std::string. I could only find 3 > Andrew> places in GDB where this was useful right now, and these all make use > Andrew> of operator+=. > > Andrew> I've also added a self test for gdb::unique_xmalloc_ptr, which > Andrew> makes use of both operator+= and operator+, so they are both getting > Andrew> used/tested. > > Looks good to me. Thanks, pushed. Andrew