From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3D83E3858D1E for ; Sat, 26 Feb 2022 20:40:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D83E3858D1E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-49-jGi_pHpJN7uUmZ7dFrmC9g-1; Sat, 26 Feb 2022 15:40:21 -0500 X-MC-Unique: jGi_pHpJN7uUmZ7dFrmC9g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 146CD653; Sat, 26 Feb 2022 20:40:20 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 958905DF3F; Sat, 26 Feb 2022 20:40:19 +0000 (UTC) Date: Sat, 26 Feb 2022 13:40:12 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/6] Handle recursive internal problem in gdb_internal_error_resync Message-ID: <20220226134012.4eac5f70@f35-zws-1> In-Reply-To: <9cce1ee1-7489-6558-9145-211097c1848e@palves.net> References: <20210822231959.184061-1-kevinb@redhat.com> <20210822231959.184061-2-kevinb@redhat.com> <9cce1ee1-7489-6558-9145-211097c1848e@palves.net> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Feb 2022 20:40:24 -0000 I've pushed this commit. On Mon, 27 Sep 2021 18:38:40 +0100 Pedro Alves wrote: > On 2021-08-23 12:19 a.m., Kevin Buettner wrote: > > I came across this problem when testing gdb.base/gdb-sigterm.exp > > on a machine with a pre-release version of glib-2.34 installed: > > > > A problem internal to GDB has been detected, > > further debugging may prove unreliable. > > Quit this debugging session? (y or n) Recursive internal problem. > > FAIL: gdb.base/gdb-sigterm.exp: expect eof #0 (GDB internal error) > > Resyncing due to internal error. > > ERROR: : spawn id exp11 not open > > while executing > > "expect { > > -i exp11 -timeout 10 > > -re "Quit this debugging session\\? \\(y or n\\) $" { > > send_gdb "n\n" answer > > incr count > > } > > -re "Create..." > > ("uplevel" body line 1) > > invoked from within > > "uplevel $body" NONE : spawn id exp11 not open > > ERROR: Could not resync from internal error (timeout) > > gdb.base/gdb-sigterm.exp: expect eof #0: stepped 9 times > > UNRESOLVED: gdb.base/gdb-sigterm.exp: 50 SIGTERM passes > > > > I don't have a problem with the latter ERROR nor the UNRESOLVED > > messages. However the first ERROR regarding the exp11 spawn id > > not being open is not especially useful. > > > > This commit handles the "Recursive internal problem" case, avoiding > > the problematic ERROR shown above. > > > > With this commit in place, the log messages look like this instead: > > > > A problem internal to GDB has been detected, > > further debugging may prove unreliable. > > Quit this debugging session? (y or n) Recursive internal problem. > > FAIL: gdb.base/gdb-sigterm.exp: expect eof #15 (GDB internal error) > > Resyncing due to internal error. > > ERROR: Could not resync from internal error (recursive internal problem) > > gdb.base/gdb-sigterm.exp: expect eof #15: stepped 12 times > > UNRESOLVED: gdb.base/gdb-sigterm.exp: 50 SIGTERM passes > > > > gdb/testsuite/ChangeLog: > > > > * lib/gdb.exp (gdb_internal_error_resync): Handle "Recursive > > internal problem". > > LGTM. >