From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A8DFB3858C78 for ; Tue, 1 Mar 2022 20:05:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8DFB3858C78 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-675-8ZGBBEsBME6mcXBxbh2tZQ-1; Tue, 01 Mar 2022 15:05:01 -0500 X-MC-Unique: 8ZGBBEsBME6mcXBxbh2tZQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33266FC82; Tue, 1 Mar 2022 20:05:00 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.17.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C308C30596; Tue, 1 Mar 2022 20:04:59 +0000 (UTC) Date: Tue, 1 Mar 2022 13:04:57 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Some "distclean" fixes in gdb Message-ID: <20220301130457.13d8467f@f35-zws-1> In-Reply-To: <20220228003358.487744-1-tom@tromey.com> References: <20220228003358.487744-1-tom@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 20:05:07 -0000 On Sun, 27 Feb 2022 17:33:58 -0700 Tom Tromey wrote: > PR build/12440 points out that "make distclean" is broken in gdb. > Most of the breakage comes from other projects in the tree, but we can > fix some of the issues, which is what this patch does. > > Note that the yacc output files, like c-exp.c, are left alone. In a > source distribution, these are included in the tarball, and if the > user builds in-tree, we would not want to remove them. > > While that seems a bit obscure, it seems to me that "distclean" is > only really useful for in-tree builds anyway -- out-of-tree I simply > delete the entire build directory and start over. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=12440 Wow, that's an old bug. Regardless, this seems reasonable to me. Kevin